From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: yuanhan.liu@linux.intel.com, john.mcnamara@intel.com,
zhiyong.yang@intel.com, dev@dpdk.org, fbaudin@redhat.com
Subject: Re: [dpdk-dev] [PATCH] doc: introduce PVP reference benchmark
Date: Mon, 28 Nov 2016 15:15:30 +0100 [thread overview]
Message-ID: <1948533.ERBNTx8Tcb@xps13> (raw)
In-Reply-To: <a85125cc-2908-c802-f099-1170416a90bd@redhat.com>
2016-11-28 15:02, Maxime Coquelin:
>
> On 11/28/2016 12:22 PM, Thomas Monjalon wrote:
> > 2016-11-23 22:00, Maxime Coquelin:
> >> +You can use this qmp-vcpu-pin script to pin vCPUs:
> >> +
> >> + .. code-block:: python
> >> +
> >> + #!/usr/bin/python
> >> + # QEMU vCPU pinning tool
> >> + #
> >> + # Copyright (C) 2016 Red Hat Inc.
> >> + #
> >> + # Authors:
> >> + # Maxime Coquelin <maxime.coquelin@redhat.com>
> >> + #
> >> + # This work is licensed under the terms of the GNU GPL, version 2. See
> >> + # the COPYING file in the top-level directory
> >> + import argparse
> >> + import json
> >> + import os
> >> +
> >> + from subprocess import call
> >> + from qmp import QEMUMonitorProtocol
> >> +
> >> + pinned = []
> >> +
> >> + parser = argparse.ArgumentParser(description='Pin QEMU vCPUs to physical CPUs')
> >> + parser.add_argument('-s', '--server', type=str, required=True,
> >> + help='QMP server path or address:port')
> >> + parser.add_argument('cpu', type=int, nargs='+',
> >> + help='Physical CPUs IDs')
> >> + args = parser.parse_args()
> >> +
> >> + devnull = open(os.devnull, 'w')
> >> +
> >> + srv = QEMUMonitorProtocol(args.server)
> >> + srv.connect()
> >> +
> >> + for vcpu in srv.command('query-cpus'):
> >> + vcpuid = vcpu['CPU']
> >> + tid = vcpu['thread_id']
> >> + if tid in pinned:
> >> + print 'vCPU{}\'s tid {} already pinned, skipping'.format(vcpuid, tid)
> >> + continue
> >> +
> >> + cpuid = args.cpu[vcpuid % len(args.cpu)]
> >> + print 'Pin vCPU {} (tid {}) to physical CPU {}'.format(vcpuid, tid, cpuid)
> >> + try:
> >> + call(['taskset', '-pc', str(cpuid), str(tid)], stdout=devnull)
> >> + pinned.append(tid)
> >> + except OSError:
> >> + print 'Failed to pin vCPU{} to CPU{}'.format(vcpuid, cpuid)
> >>
> >
> >
> > No please do not introduce such useful script in a doc.
> > I think it must be a separate file in the DPDK repository or
> > in the QEMU repository.
>
> Ok. The patch is under review on Qemu ML.
> While it gets merged, I can add a link to its patchwork ID.
> Ok for you?
Perfect, thanks
prev parent reply other threads:[~2016-11-28 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 21:00 Maxime Coquelin
2016-11-24 5:07 ` Yuanhan Liu
2016-11-24 7:35 ` Maxime Coquelin
2016-11-29 10:16 ` Yuanhan Liu
2016-11-29 10:29 ` Maxime Coquelin
2016-11-24 11:58 ` Kevin Traynor
2016-11-24 12:39 ` Maxime Coquelin
2016-11-24 17:38 ` Mcnamara, John
2016-11-25 9:29 ` Maxime Coquelin
2016-11-28 11:22 ` Thomas Monjalon
2016-11-28 14:02 ` Maxime Coquelin
2016-11-28 14:15 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1948533.ERBNTx8Tcb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=fbaudin@redhat.com \
--cc=john.mcnamara@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).