From: Thomas Monjalon <thomas@monjalon.net>
To: "Kozak, KubaX" <kubax.kozak@intel.com>
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix wrong sizeof argument in malloc function
Date: Wed, 10 May 2017 16:52:38 +0200 [thread overview]
Message-ID: <1951173.zJhoV9t8yi@xps> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA612A36772@IRSMSX102.ger.corp.intel.com>
09/05/2017 10:46, Van Haaren, Harry:
> > From: Kozak, KubaX
> > Sent: Tuesday, May 9, 2017 6:22 AM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> > Jastrzebski, MichalX K <michalx.k.jastrzebski@intel.com>; Kozak, KubaX <kubax.kozak@intel.com>
> > Subject: [PATCH] ethdev: fix wrong sizeof argument in malloc function
> >
> > From: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
> >
> > Coverity reported that an argument for sizeof was used improperly.
> > We should allocate memory for value size that pointer points to,
> > instead of pointer size itself.
> >
> > Coverity issue: 144522
> > Fixes: 79c913a42f0e ("ethdev: retrieve xstats by ID")
> >
> > Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
>
> Please consider merging these in 17.05, this is an important fix for 32 bit systems.
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>
>
> This patch fixes a bug of the same as detailed here:
> http://dpdk.org/ml/archives/dev/2017-May/065487.html
Applied with title:
ethdev: fix xstats by ID on 32-bit
Thanks
prev parent reply other threads:[~2017-05-10 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 5:22 Kuba Kozak
2017-05-09 8:46 ` Van Haaren, Harry
2017-05-10 14:52 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1951173.zJhoV9t8yi@xps \
--to=thomas@monjalon.net \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=kubax.kozak@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).