DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/2] rte_metrics: fix strncpy truncation warning
Date: Wed, 04 Apr 2018 16:33:03 +0200	[thread overview]
Message-ID: <1957924.kE1epoxS1F@xps> (raw)
In-Reply-To: <20180329170531.2478-3-stephen@networkplumber.org>

29/03/2018 19:05, Stephen Hemminger:
> Fixes:
> librte_metrics/rte_metrics.c:218:4: error: ‘strncpy’ specified
>  bound 64 equals destination size [-Werror=stringop-truncation]
>     strncpy(names[idx_name].name,
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      stats->metadata[idx_name].name,
>      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      RTE_METRICS_MAX_NAME_LEN);
>      ~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

This one is fixed with strlcpy now.

  reply	other threads:[~2018-04-04 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 17:05 [dpdk-dev] [PATCH v3 0/2] gcc-8 build fixes Stephen Hemminger
2018-03-29 17:05 ` [dpdk-dev] [PATCH v3 1/2] rte_mbuf: fix strncpy warnings Stephen Hemminger
2018-04-04 15:35   ` Thomas Monjalon
2018-03-29 17:05 ` [dpdk-dev] [PATCH v3 2/2] rte_metrics: fix strncpy truncation warning Stephen Hemminger
2018-04-04 14:33   ` Thomas Monjalon [this message]
2018-04-03  9:23 ` [dpdk-dev] [PATCH v3 0/2] gcc-8 build fixes Ferruh Yigit
2018-04-03 15:10   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1957924.kE1epoxS1F@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).