From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
"Xueming(Steven) Li" <xuemingl@mellanox.com>,
Wei Dai <wei.dai@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: force RSS offload rules again
Date: Wed, 13 Jun 2018 17:19:22 +0200 [thread overview]
Message-ID: <19602770.WDo9s5UZfG@xps> (raw)
In-Reply-To: <DB7PR05MB442643B2D97E6A18F705B55DC3670@DB7PR05MB4426.eurprd05.prod.outlook.com>
04/06/2018 09:56, Shahaf Shuler:
> Sunday, June 3, 2018 5:15 PM, Ferruh Yigit:
> > Subject: Re: [PATCH] ethdev: force RSS offload rules again
> >
> > On 6/3/2018 11:41 AM, Shahaf Shuler wrote:
> > > Thursday, May 31, 2018 4:23 PM, Ferruh Yigit:
> > >> Subject: [PATCH] ethdev: force RSS offload rules again
> > >>
> > >> PMDs should provide supported RSS hash functions via
> > >> dev_info.flow_type_rss_offloads variable.
> > >>
> > >> There is a check in ethdev if requested RSS hash function is
> > >> supported by PMD or not.
> > >> This check has been relaxed in previous release to not return an
> > >> error when a non supported has function requested [1], this has been
> > >> done to not break the applications.
> > >>
> > >> Adding the error return back.
> > >> PMDs need to provide correct list of supported hash functions and
> > >> applications need to take care this information before configuring
> > >> the RSS otherwise they will get an error from APIs:
> > >> rte_eth_dev_rss_hash_update()
> > >> rte_eth_dev_configure()
> > >
> > > Are the current app/examples in DPDK tree behave accordingly?
> >
> > I tried a few which were good but I don't know about all.
> >
> > That is why we should merge this patch early so that we can detect and fix
> > ones fails.
>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
prev parent reply other threads:[~2018-06-13 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 13:22 Ferruh Yigit
2018-06-03 10:41 ` Shahaf Shuler
2018-06-03 14:15 ` Ferruh Yigit
2018-06-04 7:56 ` Shahaf Shuler
2018-06-13 15:19 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19602770.WDo9s5UZfG@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=shahafs@mellanox.com \
--cc=wei.dai@intel.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).