From: Thomas Monjalon <thomas@monjalon.net>
To: "Chautru, Nicolas" <nicolas.chautru@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Vargas, Hernan" <hernan.vargas@intel.com>
Subject: Re: [PATCH v2 2/2] doc: simplify the binding steps
Date: Thu, 24 Nov 2022 09:21:07 +0100 [thread overview]
Message-ID: <1965125.PIDvDuAF1L@thomas> (raw)
In-Reply-To: <BY5PR11MB445174BE2E36C08838D39992F80F9@BY5PR11MB4451.namprd11.prod.outlook.com>
24/11/2022 02:09, Chautru, Nicolas:
> Hi Thomas,
>
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Wednesday, November 23, 2022 12:35 AM
> > To: Chautru, Nicolas <nicolas.chautru@intel.com>
> > Cc: dev@dpdk.org; gakhil@marvell.com; maxime.coquelin@redhat.com;
> > Vargas, Hernan <hernan.vargas@intel.com>
> > Subject: Re: [PATCH v2 2/2] doc: simplify the binding steps
> >
> > 22/11/2022 22:21, Chautru, Nicolas:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 15/11/2022 20:59, Nicolas Chautru:
> > > > > -The PCI virtual functions must be configured before working or
> > > > > getting assigned -to VMs/Containers. The configuration involves
> > > > > allocating the number of hardware
> > > > > +The device must be configured to work properly.
> > > > > +The configuration involves allocating the number of hardware
> > > > > queues, priorities, load balance, bandwidth and other settings
> > > > > necessary for the device to perform FEC functions.
> > > > >
> > > > > This configuration needs to be executed at least once after
> > > > > reboot or PCI FLR and can -be achieved by using the functions
> > > > > ``rte_acc10x_configure()``,
> > > > > +be achieved by either using ``pf_bb_config`` or the function
> > > > > +``rte_acc10x_configure()``,
> > > > > which sets up the parameters defined in the compatible
> > > > > ``acc100_conf``
> > > > structure.
> > > > > +This is the method used in the bbdev-test test application.
> > > >
> > > > Clearly this patch is more than "simplifying binding steps".
> > > >
> > >
> > > The intent has indeed to remove much of the binding steps to point to
> > generic document, then minor updates to keep the flow readable and
> > informative.
> > > Let me know what you are referring to specifically which caught your eyes.
> > > Some of the FPGA configuration steps were also simplifies to align with the
> > other PMDs.
> > > We can rename if you prefer as doc: simplify the binding and configuration
> > steps. Or split but unsure of the value. Up to you.
> >
> > You are adding more information.
> > One example is above.
> > I think it deserves a separate commit to understand which info you add and
> > why.
> >
>
> To avoid iterations, you just want to split this commit again into two:
> - doc: simplify the binding steps
> - doc: simplify and clarify the configuration steps
>
> Thanks for confirming.
> Nic
Yes
prev parent reply other threads:[~2022-11-24 8:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 19:59 [PATCH v2 0/2] doc: simplify PMD steps Nicolas Chautru
2022-11-15 19:59 ` [PATCH v2 1/2] doc: make the Linux drivers doc more generic Nicolas Chautru
2022-11-22 14:59 ` Thomas Monjalon
2023-03-06 17:41 ` Chautru, Nicolas
2023-03-06 19:46 ` Thomas Monjalon
2023-03-09 17:35 ` Chautru, Nicolas
2023-03-09 18:08 ` Thomas Monjalon
2022-11-15 19:59 ` [PATCH v2 2/2] doc: simplify the binding steps Nicolas Chautru
2022-11-22 15:01 ` Thomas Monjalon
2022-11-22 21:21 ` Chautru, Nicolas
2022-11-23 8:35 ` Thomas Monjalon
2022-11-24 1:09 ` Chautru, Nicolas
2022-11-24 8:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1965125.PIDvDuAF1L@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).