From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Karmarkar Suyash <skarmarkar@sonusnet.com>, rsanford@akamai.com
Cc: dev@dpdk.org, reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction
Date: Wed, 21 Sep 2016 22:03:38 +0200 [thread overview]
Message-ID: <19661851.bryX1Po3Jn@xps13> (raw)
In-Reply-To: <BN3PR03MB14310D01FAADE08B3E1EE384B3F60@BN3PR03MB1431.namprd03.prod.outlook.com>
Hi,
2016-09-21 17:08, Karmarkar Suyash:
> Hello,
>
> I corrected the fixes line, Can you please review the change and if no further comments can you please let me know the next steps. Thanks.
The Fixes lines is still not correct. The id ba885531ac26 do not exist.
Please check your patch with scripts/check-git-log.sh.
Karmarkar, it is preferred to use --in-reply-to when sending a new version.
Please Robert, could you check it is a right fix?
Thanks
> --- a/lib/librte_timer/rte_timer.c
> +++ b/lib/librte_timer/rte_timer.c
> @@ -613,7 +613,7 @@ void rte_timer_manage(void)
> status.owner = (int16_t)lcore_id;
> rte_wmb();
> tim->status.u32 = status.u32;
> - __rte_timer_reset(tim, cur_time + tim->period,
> + __rte_timer_reset(tim, tim->expire + tim->period,
> tim->period, lcore_id, tim->f, tim->arg, 1);
> rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
> }
next prev parent reply other threads:[~2016-09-21 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 16:02 Karmarkar Suyash
2016-09-21 17:08 ` Karmarkar Suyash
2016-09-21 20:03 ` Thomas Monjalon [this message]
2016-09-21 20:54 ` Karmarkar Suyash
2016-09-29 14:27 ` Karmarkar Suyash
2016-10-04 19:31 ` Karmarkar Suyash
2016-10-04 20:51 ` Sanford, Robert
2016-10-04 21:39 ` Sanford, Robert
2016-10-04 22:36 ` Karmarkar Suyash
2016-10-05 9:34 ` Pattan, Reshma
2016-10-05 10:06 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2016-09-16 15:58 Karmarkar Suyash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19661851.bryX1Po3Jn@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=rsanford@akamai.com \
--cc=skarmarkar@sonusnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).