DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maple <liujian@raisecom.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-maintainers] Example(Load_balancer) Tx Flush Bug(This bug DPDK each version)
Date: Mon, 16 Jan 2017 15:18:47 +0100	[thread overview]
Message-ID: <1982394.bHk3uHp29x@xps13> (raw)
In-Reply-To: <2017011619162170012425@raisecom.com>

Hi,

Sorry if you feel your patch is ignored.
It is not in the right format for several reasons we tried
to explain earlier I think.
Please read carefully this doc:
	http://dpdk.org/doc/guides/contributing/patches.html


2017-01-16 19:16, Maple:
> From: Maple <liujian@raisecom.com>
> To: <qiming.yang@intel.com>;<dev@dpdk.org>
> Cc: <maintainers@dpdk.org>
> Subject: [PATCH] Load_balancer Tx Flush Bug
> Date: Mon, 16 Dec 2017 19:15:48 +0800
> Message-Id: <1482371868-19669-1-git-send-email-liujian@raisecom.com>
> X-Mailer: git-send-email 1.9.1
> In-Reply-To: <2016122122394164225248@raisecom.com>
> References: <2016122122394164225248@raisecom.com>
> 
> We found a bug in use load_balancer example,and,This bug DPDK each version.
> In IO tx flush, only flush port 0.
> So,If I enable more than the Port,then,In addition to 0 port won't flush.
> 
> Signed-off-by: Maple <liujian@raisecom.com>
> ---
>  a/examples/load_balancer/runtime.c | 667 ++++++++++++++++++++++++++++++++++++
>  b/examples/load_balancer/runtime.c | 669 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 1336 insertions(+)
>  create mode 100644 a/examples/load_balancer/runtime.c
>  create mode 100644 b/examples/load_balancer/runtime.c
> 
> diff --git a/examples/load_balancer/runtime.c b/examples/load_balancer/runtime.c
> index 9612392..3a2e900 100644
> --- a/test/a/examples/load_balancer/runtime.c
> +++ b/test/b/examples/load_balancer/runtime.c
> @@ -418,9 +418,11 @@ app_lcore_io_tx(
>  static inline void
>  app_lcore_io_tx_flush(struct app_lcore_params_io *lp)
>  {
> +       uint8_t i;
>         uint8_t port;
> 
> -       for (port = 0; port < lp->tx.n_nic_ports; port ++) {
> +       port = lp->tx.nic_ports[0];
> +       for (i = 0; i < lp->tx.n_nic_ports; i ++) {
>                 uint32_t n_pkts;
> 
>                 if (likely((lp->tx.mbuf_out_flush[port] == 0) ||
> 

  parent reply	other threads:[~2017-01-16 14:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2016122121181642100644@raisecom.com>
     [not found] ` <2016122121292174988745@raisecom.com>
2016-12-21 14:39   ` [dpdk-dev] " Maple
2016-12-21 15:08     ` Thomas Monjalon
2016-12-22  2:05     ` [dpdk-dev] Example(Load_balancer) Tx Flush Bug(This bug dpdk " Maple
2016-12-22 13:07       ` Maple
2016-12-23  8:23         ` [dpdk-dev] Example(Load_balancer) Tx flush bug Maple
2017-01-16 11:09     ` [dpdk-dev] Example(Load_balancer) Tx Flush Bug(This bug DPDK each version) Yang, Qiming
     [not found]       ` <2017011619162170012425@raisecom.com>
2017-01-16 14:18         ` Thomas Monjalon [this message]
2017-04-27  9:35           ` [dpdk-dev] [dpdk-maintainers] " Andriy Berestovskyy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1982394.bHk3uHp29x@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=liujian@raisecom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).