From: Thomas Monjalon <thomas@monjalon.net>
To: "Patil, Harish" <Harish.Patil@cavium.com>,
Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option
Date: Mon, 01 May 2017 22:22:26 +0200 [thread overview]
Message-ID: <1984316.gczFh5jcb3@xps> (raw)
In-Reply-To: <D52CE0DB.13C49C%Harish.Patil@cavium.com>
01/05/2017 22:07, Patil, Harish:
> Hi Remy,
> Have a small suggestion here.
> Since testpmd uses new libraries of librte_latencystats and
> librte_bitratestats it hurts packet processing performance.
> Many users who use testpmd to do the initial performance benchmarks may
> not be aware of such a feature is default enabled.
Yes, the default config of testpmd must give good performance.
> So can we disable this feature by default in the config?
> · CONFIG_RTE_LIBRTE_BITRATE=n
> · CONFIG_RTE_LIBRTE_LATENCY_STATS=n
> Only those folks interested in latency/jitter measurements can recompile
> with those configs enabled.
I disagree about compile-time options.
It should be a run-time option of testpmd.
Please Remy (or others),
disable the metrics in the default configuration of testpmd,
before the 17.05 release.
You have few days, it is urgent.
next prev parent reply other threads:[~2017-05-01 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 13:02 [dpdk-dev] [PATCH v1] " Remy Horton
2017-04-28 8:21 ` Wu, Jingjing
2017-04-28 11:00 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-05-01 13:49 ` Thomas Monjalon
2017-05-01 20:07 ` Patil, Harish
2017-05-01 20:22 ` Thomas Monjalon [this message]
2017-05-02 11:18 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1984316.gczFh5jcb3@xps \
--to=thomas@monjalon.net \
--cc=Harish.Patil@cavium.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).