DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/distributor: fix missing "; " in debug macro
Date: Fri, 05 Jun 2015 22:45:04 +0200	[thread overview]
Message-ID: <19910784.6F5piXXB0d@xps13> (raw)
In-Reply-To: <1433520077-11234-1-git-send-email-bruce.richardson@intel.com>

2015-06-05 17:01, Bruce Richardson:
> The macro to turn on additional debug output when the app was compiled
> with "-DDEBUG" was missing a ";".

It shows that such dead code is almost never tested.
It would be saner if this command would return no result:
	git grep 'ifdef.*DEBUG' examples
		examples/distributor/main.c:#ifdef DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/packet_ordering/main.c:#ifdef DEBUG
		examples/vhost/main.c:#ifdef DEBUG
		examples/vhost/main.h:#ifdef DEBUG
		examples/vhost_xen/main.c:#ifdef DEBUG
		examples/vhost_xen/main.h:#ifdef DEBUG

There is no good reason to not use CONFIG_RTE_LOG_LEVEL to trigger debug build.

  reply	other threads:[~2015-06-05 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 16:01 Bruce Richardson
2015-06-05 20:45 ` Thomas Monjalon [this message]
2015-06-08 10:58   ` Bruce Richardson
2015-06-10  0:33     ` Stephen Hemminger
2015-06-22 20:53     ` Thomas Monjalon
2015-06-23 16:00       ` Bruce Richardson
2015-06-22 20:36 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19910784.6F5piXXB0d@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).