From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>,
Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist existence while freeing rxq
Date: Sun, 13 Dec 2015 00:55:03 +0100 [thread overview]
Message-ID: <1999328.glrlqgBIyh@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE202403460@IRSMSX103.ger.corp.intel.com>
> > When refilling freelists for the first time and if it fails, the rxq is
> > freed and returns ENOMEM. There is a check while freeing hardware rxq to
> > pass freelist context id if the freelist exists or 0xffff otherwise.
> > The error path is only reached if freelist exists. So, fix is to remove
> > the useless check for freelist existence.
> >
> > Thanks to John McNamara <john.mcnamara@intel.com> for reporting it.
> >
> > Coverity issue: 107108
> > Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")
> >
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> > Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
>
> Thanks for updating the Coverity Triage for the issue.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-12-12 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 8:25 Rahul Lakkireddy
2015-12-11 14:44 ` Mcnamara, John
2015-12-12 23:55 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1999328.glrlqgBIyh@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=felix@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).