From: "Tahhan, Maryam" <maryam.tahhan@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and error stats
Date: Tue, 3 Nov 2015 13:14:52 +0000 [thread overview]
Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A5E618C@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <3108772.cu7MlmvWl0@xps13>
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, November 2, 2015 11:47 PM
> To: Tahhan, Maryam <maryam.tahhan@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and
> error stats
>
> 2015-10-19 13:20, Maryam Tahhan:
> > Make a distniction between dropped packets and error statistics to
> > allow a higher level fault management entity to interact with DPDK and
> > take appropriate measures when errors are detected. It will also
> > provide valuable information for any applications that
> > collects/extracts DPDK stats, such applications include Open vSwitch.
> > After this patch the distinction is:
> > ierrors = Total number of packets dropped by hardware (malformed
> > packets, ...) Where the # of drops can ONLY be <= the packets
> > received (without overlap between registers).
> > ipkterrors = Total number of erroneous received packets. Where the #
> > of errors can be >= the packets received (without overlap between
> > registers), this is because there may be multiple errors associated
> > with a packet.
> [...]
> > - uint64_t ierrors; /**< Total number of erroneous received packets.
> */
> > + uint64_t ierrors;
> > + /**< Total number of packets dropped by hardware (malformed
> packets...)
> > + * Where the # of drops can ONLY be <= the packets received
> (without
> > + * overlap between registers).
> > + */
> > uint64_t oerrors; /**< Total number of failed transmitted packets. */
> > + uint64_t ipkterrors;
> > + /**< Total number of erroneous received packets. Where the
> number of
> > + * errors can be >= the packets received (without overlap between
> > + * registers), this is because there may be multiple errors associated
> with
> > + * a packet.
> > + */
>
> There was not a lot of comments on this proposal.
> If the idea is well received, it needs to be implemented in drivers, at least few
> of them.
Hi Thomas
I was waiting to implement it across the drivers when I knew it was going to be merged to master. It shouldn't break anything that's currently using ethdev stats and should be relatively straight forward to implement for the drivers. Does it makes sense to add it into drivers now or wait for the next open DPDK window?
Thanks
Maryam
next prev parent reply other threads:[~2015-11-03 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:20 Maryam Tahhan
2015-11-02 23:46 ` Thomas Monjalon
2015-11-03 13:14 ` Tahhan, Maryam [this message]
2015-11-03 13:55 ` Thomas Monjalon
2015-11-03 14:56 ` Tahhan, Maryam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A27633A6DA49C4A92FCD5D4312DBF536A5E618C@IRSMSX109.ger.corp.intel.com \
--to=maryam.tahhan@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).