From: "Wiles, Keith" <keith.wiles@intel.com>
To: Pascal Mazon <pascal.mazon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix dev name look-up
Date: Fri, 3 Mar 2017 15:19:41 +0000 [thread overview]
Message-ID: <1D7A781E-071D-4F3D-BC82-FD9A9338953E@intel.com> (raw)
In-Reply-To: <1ad979ca71ba1ebe10572237a6a5b4694c23b645.1488531158.git.pascal.mazon@6wind.com>
> On Mar 3, 2017, at 2:54 AM, Pascal Mazon <pascal.mazon@6wind.com> wrote:
>
> The call to rte_eth_dev_allocate(tap_name) sets dev->data->name to
> tap_name (e.g. "dtap0").
>
> A look-up using tap_name is expected to return this device, not a
> look-up using name (e.g. "net_tap0").
>
> Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
Acked-by: Keith Wiles <keith.wiles@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 47a706070652..14c345f07afa 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -691,7 +691,7 @@ eth_dev_tap_create(const char *name, char *tap_name)
> dev->driver = NULL;
> dev->rx_pkt_burst = pmd_rx_burst;
> dev->tx_pkt_burst = pmd_tx_burst;
> - snprintf(dev->data->name, sizeof(dev->data->name), "%s", name);
> + snprintf(dev->data->name, sizeof(dev->data->name), "%s", tap_name);
>
> /* Presetup the fds to -1 as being not valid */
> for (i = 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) {
> --
> 2.8.0.rc0
>
Regards,
Keith
next prev parent reply other threads:[~2017-03-03 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 8:54 Pascal Mazon
2017-03-03 15:19 ` Wiles, Keith [this message]
2017-03-05 21:35 ` Ferruh Yigit
2017-03-06 14:15 ` Wiles, Keith
2017-03-06 14:32 ` Ferruh Yigit
2017-03-06 13:51 ` [dpdk-dev] [PATCH v2] " Pascal Mazon
2017-03-06 14:27 ` Ferruh Yigit
2017-03-06 14:57 ` Pascal Mazon
2017-03-06 15:13 ` [dpdk-dev] [PATCH v3] " Pascal Mazon
2017-03-06 15:16 ` Wiles, Keith
2017-03-06 15:42 ` Ferruh Yigit
2017-03-06 16:03 ` Ferruh Yigit
2017-03-06 16:14 ` Wiles, Keith
2017-03-08 17:44 ` Ferruh Yigit
2017-03-06 15:41 ` Ferruh Yigit
2017-03-06 15:55 ` Pascal Mazon
2017-03-06 16:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1D7A781E-071D-4F3D-BC82-FD9A9338953E@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=pascal.mazon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).