From: "Liu, Jijiang" <jijiang.liu@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd:test RX tunnel filter for NVGRE packet
Date: Fri, 13 Feb 2015 01:27:14 +0000 [thread overview]
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DDAE21@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8BA72B3@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, February 13, 2015 9:23 AM
> To: Liu, Jijiang; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 3/4] app/testpmd:test RX tunnel filter for
> NVGRE packet
>
> Hi, jijiang
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> > Sent: Thursday, February 12, 2015 8:46 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 3/4] app/testpmd:test RX tunnel filter
> > for NVGRE packet
> >
> > Extend the "tunnel_filter" command in testpmd to test the RX tunnel
> > filter API for NVGRE packet.
> >
> > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> > ---
> > app/test-pmd/cmdline.c | 14 ++++++++------
> > 1 files changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > 9de3e7e..a380d43 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -293,11 +293,11 @@ static void cmd_help_long_parsed(void
> > *parsed_result,
> > " a port\n\n"
> >
> > "tunnel_filter add (port_id) (outer_mac) (inner_mac)
> > (ip_addr) "
> > - "(inner_vlan) (tunnel_type) (filter_type) (tenant_id)
> > (queue_id)\n"
> > + "(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id)
> > (queue_id)\n"
> > " add a tunnel filter of a port.\n\n"
> >
> > "tunnel_filter rm (port_id) (outer_mac) (inner_mac)
> > (ip_addr) "
> > - "(inner_vlan) (tunnel_type) (filter_type) (tenant_id)
> > (queue_id)\n"
> > + "(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id)
> > (queue_id)\n"
> > " remove a tunnel filter of a port.\n\n"
> >
> > "rx_vxlan_port add (udp_port) (port_id)\n"
> > @@ -6851,8 +6851,10 @@ cmd_tunnel_filter_parsed(void *parsed_result,
> >
> > if (!strcmp(res->tunnel_type, "vxlan"))
> > tunnel_filter_conf.tunnel_type = RTE_TUNNEL_TYPE_VXLAN;
> > + if (!strcmp(res->tunnel_type, "nvgre"))
> > + tunnel_filter_conf.tunnel_type =
> > RTE_TUNNEL_TYPE_NVGRE;
> > else {
> > - printf("Only VXLAN is supported now.\n");
> > + printf("The tunnel type is supported now.\n");
>
> Maybe "not" is missed in the printed sentence. Or you can just remove the else
> {}, because res->tunnel_type can only be "vxlan" or "nvgre".
I'll update it in next version.
> > return;
> > }
> >
> > @@ -6896,12 +6898,12 @@ cmdline_parse_token_ipaddr_t
> > cmd_tunnel_filter_ip_value =
> > ip_value);
> > cmdline_parse_token_string_t cmd_tunnel_filter_tunnel_type =
> > TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result,
> > - tunnel_type, "vxlan");
> > + tunnel_type, "vxlan#nvgre");
> >
> > cmdline_parse_token_string_t cmd_tunnel_filter_filter_type =
> > TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result,
> > filter_type, "imac-ivlan#imac-ivlan-tenid#imac-tenid#"
> > - "imac#omac-imac-tenid");
> > + "imac#omac-imac-tenid#");
>
>
> Do you need the additional "#"?
Don't need it, I'll update it in next version.
> > cmdline_parse_token_num_t cmd_tunnel_filter_tenant_id =
> > TOKEN_NUM_INITIALIZER(struct cmd_tunnel_filter_result,
> > tenant_id, UINT32);
> > @@ -6914,7 +6916,7 @@ cmdline_parse_inst_t cmd_tunnel_filter = {
> > .data = (void *)0,
> > .help_str = "add/rm tunnel filter of a port: "
> > "tunnel_filter add port_id outer_mac inner_mac ip "
> > - "inner_vlan tunnel_type(vxlan) filter_type "
> > + "inner_vlan tunnel_type(vxlan|nvgre) filter_type "
> > "(imac-ivlan|imac-ivlan-tenid|imac-tenid|"
> > "imac|omac-imac-tenid) "
> > "tenant_id queue_num",
> > --
> > 1.7.7.6
next prev parent reply other threads:[~2015-02-13 1:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 0:45 [dpdk-dev] [PATCH v2 0/4] Support NVGRE on i40e Jijiang Liu
2015-02-12 0:45 ` [dpdk-dev] [PATCH v2 1/4] librte_ether:add an ETHER_TYPE_TEB macro Jijiang Liu
2015-02-12 0:45 ` [dpdk-dev] [PATCH v2 2/4] i40e:support RX tunnel filter for NVGRE packet Jijiang Liu
2015-02-12 0:45 ` [dpdk-dev] [PATCH v2 3/4] app/testpmd:test " Jijiang Liu
2015-02-13 1:23 ` Wu, Jingjing
2015-02-13 1:27 ` Liu, Jijiang [this message]
2015-02-12 0:45 ` [dpdk-dev] [PATCH v2 4/4] app/testpmd:test NVGRE Tx checksum offload Jijiang Liu
2015-02-13 9:52 ` Olivier MATZ
2015-02-15 1:13 ` Liu, Jijiang
2015-02-20 17:01 ` [dpdk-dev] [PATCH v3 0/4] Support NVGRE on i40e Declan Doherty
2015-02-20 17:01 ` [dpdk-dev] [PATCH v3 1/4] librte_ether:add an ETHER_TYPE_TEB macro Declan Doherty
2015-02-20 17:01 ` [dpdk-dev] [PATCH v3 2/4] i40e:support RX tunnel filter for NVGRE packet Declan Doherty
2015-02-20 17:01 ` [dpdk-dev] [PATCH v3 3/4] app/testpmd:test " Declan Doherty
2015-02-20 17:01 ` [dpdk-dev] [PATCH v3 4/4] app/testpmd:test NVGRE Tx checksum offload Declan Doherty
2015-02-23 15:42 ` [dpdk-dev] [PATCH v3 0/4] Support NVGRE on i40e Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ED644BD7E0A5F4091CF203DAFB8E4CC01DDAE21@SHSMSX101.ccr.corp.intel.com \
--to=jijiang.liu@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).