From: "Liu, Jijiang" <jijiang.liu@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue of valid_group in the delete_depth_small()
Date: Mon, 2 Nov 2015 08:05:11 +0000 [thread overview]
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BC738D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20151030142227.GB10520@bricha3-MOBL3>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, October 30, 2015 10:22 PM
> To: Liu, Jijiang
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue of
> valid_group in the delete_depth_small()
>
> On Fri, Oct 30, 2015 at 09:14:39PM +0800, Jijiang Liu wrote:
>
> Title can be shortened to: "lpm: fix initialization of valid_group field"
Ok
> > Fixes an initialization issue of 'valid_group' in the delete_depth_small
> function.
> >
> > In this function, use new rte_lpm_tbl8_entry we call A to replace the
> > old rte_lpm_tbl8_entry. But the valid_group do not set VALID, so it will be
> INVALID.
> >
> > Then when adding a new route which depth is > 24,the tbl8_alloc()
> > function will search the rte_lpm_tbl8_entrys to find INVALID valid_group,
> and it will return the A to the add_depth_big function, so A's data is
> overridden.
> >
>
> Not sure this message is entirely clear.
> How about:
> When adding an entry to a tbl8, the .valid_group field should always be set,
> so that future adds do not accidently find and use this table, thinking it is
> currently invalid, i.e. unused, and thereby overwrite existing entries.
It is ok for me.
Nana, what do you think?
> > Signed-off-by: NaNa <nana.nn@alibaba-inc.com>
> >
> > ---
> > lib/librte_lpm/rte_lpm.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index
> > 57ec2f0..3981452 100644
> > --- a/lib/librte_lpm/rte_lpm.c
> > +++ b/lib/librte_lpm/rte_lpm.c
> > @@ -769,6 +769,7 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t
> > ip_masked,
> >
> > struct rte_lpm_tbl8_entry new_tbl8_entry = {
> > .valid = VALID,
> > + .valid_group = VALID,
> > .depth = sub_rule_depth,
> > .next_hop = lpm->rules_tbl
> > [sub_rule_index].next_hop,
> > --
> > 1.7.7.6
> >
next prev parent reply other threads:[~2015-11-02 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 13:14 [dpdk-dev] [PATCH v2 0/2] Fix two issues in lpm Jijiang Liu
2015-10-30 13:14 ` [dpdk-dev] [PATCH v2 1/2] lib/lpm:fix an issue of condition check in delete_depth_small() Jijiang Liu
2015-10-30 14:13 ` Bruce Richardson
2015-10-30 13:14 ` [dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue of valid_group in the delete_depth_small() Jijiang Liu
2015-10-30 14:22 ` Bruce Richardson
2015-10-30 14:24 ` Bruce Richardson
2015-10-30 14:31 ` Thomas Monjalon
2015-10-30 14:56 ` Richardson, Bruce
2015-11-02 8:05 ` Liu, Jijiang [this message]
2015-11-01 18:43 ` [dpdk-dev] [PATCH v2 0/2] Fix two issues in lpm Thomas Monjalon
2015-11-02 8:09 ` Liu, Jijiang
2015-11-02 8:25 ` Thomas Monjalon
2015-11-02 8:34 ` Liu, Jijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ED644BD7E0A5F4091CF203DAFB8E4CC22BC738D@SHSMSX101.ccr.corp.intel.com \
--to=jijiang.liu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).