From: "Hunt, David" <david.hunt@intel.com>
To: Harman Kalra <hkalra@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"ferruh.yigit@linux.intel.com" <ferruh.yigit@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3 1/2] test/distributor: fix flush with worker shutdown test
Date: Wed, 17 Jul 2019 16:30:53 +0100 [thread overview]
Message-ID: <1a4c963a-6d89-7c42-905b-afc71366f460@intel.com> (raw)
In-Reply-To: <1562321046-25195-1-git-send-email-hkalra@marvell.com>
Hi Harman,
On 05/07/2019 11:05, Harman Kalra wrote:
> On restarting worker 0 after shutdown, packets handled by
> worker 0 must be incremented only when a packet is received by
> it.
>
> Fixes: c3eabff124e6 ("distributor: add unit tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
> app/test/test_distributor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
> index 8084c0794..5d71bf87c 100644
> --- a/app/test/test_distributor.c
> +++ b/app/test/test_distributor.c
> @@ -374,7 +374,8 @@ handle_work_for_shutdown_test(void *arg)
> id, buf, buf, num);
>
> while (!quit) {
> - worker_stats[id].handled_packets++, count++;
> + worker_stats[id].handled_packets += num;
> + count += num;
> rte_pktmbuf_free(pkt);
> num = rte_distributor_get_pkt(d, id, buf, buf, num);
> }
Change makes sense. Builds OK, Runs OK, test passes.
Acked-by: David Hunt <david.hunt@intel.com>
prev parent reply other threads:[~2019-07-17 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <223181000.veHZD1QNU4@xps>
2019-07-05 10:05 ` Harman Kalra
2019-07-05 10:05 ` [dpdk-stable] [PATCH v3 2/2] distributor: fix additional check on no of workers Harman Kalra
2019-07-16 10:51 ` Thomas Monjalon
2019-07-17 15:32 ` Hunt, David
2019-07-17 20:37 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-07-17 15:30 ` Hunt, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a4c963a-6d89-7c42-905b-afc71366f460@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@linux.intel.com \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).