From: Ray Kinsella <mdr@ashroe.eu>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity
Date: Thu, 12 Dec 2019 11:07:08 +0000 [thread overview]
Message-ID: <1b4c6555-158d-fcae-234d-a419abb9e15d@ashroe.eu> (raw)
In-Reply-To: <43127c39-c819-5126-47c3-6b8f793ccc62@intel.com>
On 11/12/2019 11:19, Ferruh Yigit wrote:
> On 12/11/2019 11:14 AM, Bruce Richardson wrote:
>> On Wed, Dec 11, 2019 at 12:08:25PM +0100, Thomas Monjalon wrote:
>>> 11/12/2019 12:04, Luca Boccassi:
>>>> On Wed, 2019-12-11 at 10:26 +0000, Bruce Richardson wrote:
>>>>> The soname for each stable ABI version should be just the ABI version
>>>>> major
>>>>> number without the minor number. Unfortunately both major and minor
>>>>> were
>>>>> used causing version 20.1 to be incompatible with 20.0.
>>>>>
>>>>> This patch fixes the issue by switching from 2-part to 3-part ABI
>>>>> version
>>>>> numbers so that we can keep 20.0 as soname and using the final digits
>>>>> to
>>>>> identify the 20.x releases which are ABI compatible. This requires
>>>>> changes
>>>>> to both make and meson builds to handle the three-digit version and
>>>>> shrink
>>>>> it to 2-digit for soname.
>>>>>
>>>>> Fixes: cba806e07d6f ("build: change ABI versioning to global")
>>>>>
>>>>> Signed-off-by: Thomas Monjalon <
>>>>> thomas@monjalon.net
>>>>>>
>>>>> Signed-off-by: Bruce Richardson <
>>>>> bruce.richardson@intel.com
>>>>>>
>>>>> ---
>>>>>
>>>>> This patch contains an alternative fix to that implied by the
>>>>> previous patches:
>>>>> http://patches.dpdk.org/patch/63726/
>>>>>
>>>>> http://patches.dpdk.org/patch/63728/
>>>>>
>>>>>
>>>>> ---
>>>>> ABI_VERSION | 2 +-
>>>>> drivers/meson.build | 4 ++--
>>>>> lib/meson.build | 4 ++--
>>>>> mk/rte.lib.mk | 5 ++++-
>>>>> 4 files changed, 9 insertions(+), 6 deletions(-)
>>>>
>>>> Acked-by: Luca Boccassi <bluca@debian.org>
>>>>
>>>> Thank you! I've set a reminder in my calendar for September to revert
>>>> it :-)
>>>
>>> I don't think we need to revert it.
>>> The ABI version will have only 2 numbers (21.0).
>>> In makefile there is no change.
>>> What needs to be changed in meson?
>>>
>> We need to remove the explicit use of so_version, and let meson just do the
>> right thing with the lib version. That being said, I can see about having
>> meson behave as make so that it will work even if we forget (i.e. even with
>> changed behaviour we should still remove the explicit soversion usage when
>> it's no longer needed).
>>
>
> Current major become two digits, "20.0", I think we fix it to single digit,
> "21", again in 20.11.
>
> I suggest adding this to deprecation notice document, with 20.11 target, so it
> can stay there and remind us the change.
>
+1, we do.
So name, should be comprised of the library name and the major version only.
Ray K
next prev parent reply other threads:[~2019-12-12 11:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 10:26 Bruce Richardson
2019-12-11 11:04 ` Luca Boccassi
2019-12-11 11:08 ` Thomas Monjalon
2019-12-11 11:14 ` Bruce Richardson
2019-12-11 11:19 ` Ferruh Yigit
2019-12-12 11:07 ` Ray Kinsella [this message]
2019-12-11 11:11 ` Bruce Richardson
2019-12-11 11:25 ` Ferruh Yigit
2019-12-12 11:14 ` Ray Kinsella
2019-12-12 13:58 ` Luca Boccassi
2019-12-12 14:05 ` Ray Kinsella
2019-12-12 15:08 ` Bruce Richardson
2019-12-11 11:15 ` Ferruh Yigit
2019-12-11 13:14 ` Bruce Richardson
2019-12-11 15:16 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2019-12-12 8:27 ` David Marchand
2019-12-12 8:57 ` Ferruh Yigit
2019-12-12 11:44 ` Bruce Richardson
2019-12-12 11:59 ` Bruce Richardson
2019-12-12 13:41 ` Thomas Monjalon
2019-12-12 11:58 ` [dpdk-dev] [PATCH v3] " Bruce Richardson
2019-12-12 12:30 ` Ray Kinsella
2019-12-12 13:02 ` Bruce Richardson
2019-12-12 15:25 ` Ray Kinsella
2019-12-12 15:34 ` Bruce Richardson
2019-12-12 14:45 ` Ferruh Yigit
2019-12-12 16:34 ` Ray Kinsella
2019-12-13 11:38 ` Neil Horman
2019-12-16 11:21 ` Laatz, Kevin
2019-12-19 12:42 ` David Marchand
2019-12-19 15:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b4c6555-158d-fcae-234d-a419abb9e15d@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).