From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [PATCH] net/tap: add deprecation notice for RTE_FLOW_ACTION_RSS
Date: Thu, 14 Dec 2023 18:03:45 +0000 [thread overview]
Message-ID: <1bf6e789-4939-4044-851f-b10f8f0c7d30@amd.com> (raw)
In-Reply-To: <20231214174951.8317-1-stephen@networkplumber.org>
On 12/14/2023 5:49 PM, Stephen Hemminger wrote:
> The BPF infrastructure in kernel changed which broke the method
> being used to load the RSS part of rte_flow in the TAP device.
> Since this is a little used feature, and fixing the problem would
> be moderately complex and create new dependency on libbpf,
> mark the feature as deprecated and plan for removal.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 81b93515cbd9..7d9012ada2d7 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -146,3 +146,8 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* tap: The support for RTE_FLOW_ACTION_TYPE_RSS is deprecated and
> + will be removed in DPDK 24.11 release. It is already broken on recent
> + Linux kernels due to changes in how BPF programs are loaded,
> + and will not be fixed.
>
It wasn't even building until Stephen fixed it. It is an effort to keep
it functional, unless someone commits on maintaining the feature I am
for removing it.
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
next prev parent reply other threads:[~2023-12-14 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 17:49 Stephen Hemminger
2023-12-14 18:03 ` Ferruh Yigit [this message]
2023-12-14 18:48 ` kumaraparameshwaran rathinavel
2023-12-15 3:01 ` Stephen Hemminger
2023-12-15 4:58 ` kumaraparameshwaran rathinavel
2023-12-15 3:57 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bf6e789-4939-4044-851f-b10f8f0c7d30@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).