From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Rong, Leyi" <leyi.rong@intel.com>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3] net/i40e: fix offload flag checking in simple Tx datapath
Date: Wed, 12 May 2021 08:48:17 +0000 [thread overview]
Message-ID: <1cc3bde5a3ba4d0fbc6214da894e0811@intel.com> (raw)
In-Reply-To: <SN6PR11MB26210A70D901B5FF87BE998EEC539@SN6PR11MB2621.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Rong, Leyi <leyi.rong@intel.com>
> Sent: Tuesday, May 11, 2021 5:20 PM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v3] net/i40e: fix offload flag checking in simple Tx
> datapath
>
>
> > -----Original Message-----
> > From: Zhang, AlvinX <alvinx.zhang@intel.com>
> > Sent: Tuesday, May 11, 2021 4:46 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Rong, Leyi
> > <leyi.rong@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v3] net/i40e: fix offload flag checking in simple Tx
> > datapath
> >
> > Tx offload flags 'PKT_TX_IPV6, PKT_TX_IPV4, PKT_TX_OUTER_IPV6,
> > PKT_TX_OUTER_IPV4' are supported in simple datapath.
> >
> > This patch removes these offload flags from packet checking in simple
> > Tx datapath and defines 2 macro I40E_TX_OFFLOAD_SIMPLE_SUP_MASK
> and
> > I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK.
> >
> > Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx
> > datapath")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> >
> > v3: Update codes according to comments
> > ---
> > drivers/net/i40e/i40e_rxtx.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_rxtx.c
> > b/drivers/net/i40e/i40e_rxtx.c index 02cf5e7..337916b 100644
> > --- a/drivers/net/i40e/i40e_rxtx.c
> > +++ b/drivers/net/i40e/i40e_rxtx.c
> > @@ -72,6 +72,15 @@
> > #define I40E_TX_OFFLOAD_NOTSUP_MASK \
> > (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)
> >
> > +#define I40E_TX_OFFLOAD_SIMPLE_SUP_MASK ( \
> > + PKT_TX_IPV4 | \
> > + PKT_TX_IPV6 | \
> > + PKT_TX_OUTER_IPV4 | \
> > + PKT_TX_OUTER_IPV6)
> > +
> > +#define I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK \
> > + (PKT_TX_OFFLOAD_MASK ^
> > I40E_TX_OFFLOAD_SIMPLE_SUP_MASK)
> > +
> > int
> > i40e_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond
> > *pmc) { @@ -1501,7 +1510,7 @@
> > return i;
> > }
> >
> > - if (ol_flags & PKT_TX_OFFLOAD_MASK) {
> > + if (ol_flags & I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK) {
> > rte_errno = ENOTSUP;
> > return i;
> > }
> > --
> > 1.8.3.1
>
> Acked-by: Leyi Rong <leyi.rong@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2021-05-12 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 8:58 [dpdk-stable] [PATCH] " Alvin Zhang
2021-05-06 5:32 ` [dpdk-stable] [dpdk-dev] " Zhou, JunX W
2021-05-10 3:27 ` Rong, Leyi
2021-05-11 2:39 ` [dpdk-stable] [PATCH v2] " Alvin Zhang
2021-05-11 8:08 ` Rong, Leyi
2021-05-11 8:45 ` [dpdk-stable] [PATCH v3] " Alvin Zhang
2021-05-11 9:20 ` Rong, Leyi
2021-05-12 8:48 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cc3bde5a3ba4d0fbc6214da894e0811@intel.com \
--to=qi.z.zhang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).