From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qiming Yang <qiming.yang@intel.com>, dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Helin Zhang <helin.zhang@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] net: optimize Rx/Tx log message level
Date: Tue, 6 Dec 2016 10:51:17 +0000 [thread overview]
Message-ID: <1cf27486-99cb-1a3d-a067-cd44ac38c333@intel.com> (raw)
In-Reply-To: <1480761783-36467-1-git-send-email-qiming.yang@intel.com>
Hi Qiming,
On 12/3/2016 10:43 AM, Qiming Yang wrote:
> These three patches optimized the level of Rx and Tx log
> messages. Add a new log control function PMD_RX_FREE_LOG
> to control the Rx message which is not printed in packet
> receive processing. This function switched by macro
> RTE_LIBRTE_<PMD>_DEBUG_RX_FREE.
Please CC the maintainers,
CC: Wenzhuo Lu <wenzhuo.lu@intel.com>
CC: Konstantin Ananyev <konstantin.ananyev@intel.com>, Helin Zhang
<helin.zhang@intel.com>
CC: Jingjing Wu <jingjing.wu@intel.com>
1- Do we really need a new config option just for this log function, we
already may have more config options?
2- Do we really need this new logging function at all? This is to report
when receive descriptor tail updated, as far as I can see. What is the
use case that makes this case so special?
3- Log level of some messages are increased, like mbuf allocation
failure message level increased to ERR, what is the expectation here? In
high throughput traffic this may cause lots of noise, and what user can
do with this message? If user can't do anything, why we bloating user
with error messages? There is already a dynamic counter, I believe which
is good thing to the for this error, and debug level logging.
Overall I am for rejecting this patchset, unless there is a good
justification for new debug log macro.
Thanks,
ferruh
prev parent reply other threads:[~2016-12-06 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 10:43 Qiming Yang
2016-12-03 10:43 ` [dpdk-dev] [PATCH 1/3] net/e1000: " Qiming Yang
2016-12-06 22:41 ` Stephen Hemminger
2016-12-03 10:43 ` [dpdk-dev] [PATCH 2/3] net/i40e: " Qiming Yang
2016-12-03 10:43 ` [dpdk-dev] [PATCH 3/3] net/ixgbe: " Qiming Yang
2016-12-06 10:51 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cf27486-99cb-1a3d-a067-cd44ac38c333@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).