From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ophir Munk <ophirmu@mellanox.com>,
Pascal Mazon <pascal.mazon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter
Date: Sun, 21 Jan 2018 14:20:46 +0000 [thread overview]
Message-ID: <1d1eec0e-d6cc-2329-2a71-f735821afa1a@intel.com> (raw)
In-Reply-To: <AM0PR0502MB38758F936ED700E7F7354A56D1EE0@AM0PR0502MB3875.eurprd05.prod.outlook.com>
On 1/20/2018 9:25 PM, Ophir Munk wrote:
> Hi Ferruh,
> Thanks for applying v5 patches while changing the order of commits and adding "Acked-by: ..."
>
> I have sent v6 which does the same but also updates the commit messages of the switched commits to reflect more accurately the new order.
>
> Please let know if you are going to leave v5 as is or replace it with v6.
I will drop existing ones and get your v6.
>
> Regards,
> Ophir
>
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Saturday, January 20, 2018 6:16 PM
>> To: Pascal Mazon <pascal.mazon@6wind.com>; Ophir Munk
>> <ophirmu@mellanox.com>; dev@dpdk.org
>> Cc: Thomas Monjalon <thomas@monjalon.net>; Olga Shern
>> <olgas@mellanox.com>
>> Subject: Re: [dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter
>>
>> On 1/19/2018 6:48 AM, Pascal Mazon wrote:
>>> Hi,
>>>
>>> It seems more logical to me to introduce tap_program (patch 3) before
>>> its compiled version (patch 2).
>>> Source code is indeed written down before compiling it.
>>>
>>> The doc section is a good addition.
>>> I'll be happy to see the upcoming utility for turning eBPF bytecode to
>>> C arrays.
>>> I'd have liked to see automation code (in a not-executed Makefile
>>> target
>>> typically) for generating the bytecode.
>>> I'm being told it should happen in the upcoming series along with the
>>> aforementioned utility.
>>>
>>> Otherwise code looks good enough (I couldn't see everything for lack
>>> of time), considering that later patches are expected in next release.
>>>
>>> Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
>>>
>>> Best regards,
>>> Pascal
>>>
>>> On 18/01/2018 14:38, Ophir Munk wrote:
>>>> The patches of TAP RSS eBPF follow the RFC on this issue
>>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp
>>>>
>> dk.org%2Fdev%2Fpatchwork%2Fpatch%2F31781%2F&data=02%7C01%7Cop
>> hirmu%40
>>>>
>> mellanox.com%7Ccd9b412a6c1d428fe52308d56021141b%7Ca652971c7d2e
>> 4d9ba6a
>>>>
>> 4d149256f461b%7C0%7C0%7C636520617565078480&sdata=7AuH4FxyKlZR
>> %2Fwy6%2
>>>> B3hEnW3UQIWmGonkq%2FtAxPdEG2w%3D&reserved=0
>>>>
>>>> v5 changes with respect to v4
>>>> =============================
>>>> Update TAP document guide with RSS
>>>>
>>>> v4 changes with respect to v3
>>>> =============================
>>>> * Code updates based on review comments
>>>> * New commits organization (2-->5) based on review comments
>>>> 1. net/tap: support actions for different classifiers (preparations for BPF.
>>>> No BPF code yet)
>>>> 2. net/tap: add eBPF bytes code (BPF bytes code in a separate file)
>>>> 3. net/tap: add eBPF program file (Program source code of bytes code)
>>>> 4. net/tap: add eBPF API (BPF API to be used by TAP)
>>>> 5. net/tap: implement TAP RSS using eBPF
>>>>
>>>> v3 changes with respect to v2
>>>> =============================
>>>> * Add support for IPv6 RSS in BPF program
>>>> * Bug fixes
>>>> * Updated compatibility to kernel versions:
>>>> eBPF requires Linux version 4.9 configured with BPF
>>>> * New license header (SPDX) for newly added files
>>>>
>>>> v2 changes with respect to v1
>>>> =============================
>>>> * v2 has new commits organization (3 --> 2)
>>>> * BPF program was revised. It is successfully tested on
>>>> IPv4 L3 L4 layers (compatible to mlx4 device)
>>>> * Licensing: no comments received for using "Dual BSD/GPL"
>>>> string during BPF program loading to the kernel.
>>>> (v1 and v2 are using the same license strings)
>>>> Any comments are welcome.
>>>> * Compatibility to kernel versions:
>>>> eBPF requires Linux version 4.2 configured with BPF. TAP PMD will
>>>> successfully compile on systems with old or non-BPF configured kernels.
>>>> During compilation time the required Linux headers are searched for.
>>>> If they are not present missing definitions are locally added
>>>> (tap_autoconf.h).
>>>> If the kernel cannot support a BPF operation - at runtime it will
>>>> gracefully reject the netlink message (with BPF) sent to it.
>>>>
>>>> Ophir Munk (6):
>>>> net/tap: support actions for different classifiers
>>>> net/tap: add eBPF bytes code
>>>> net/tap: add eBPF program file
>>>> net/tap: add eBPF API
>>>> net/tap: implement TAP RSS using eBPF
>>>> doc: detail new tap RSS feature in guides
>>
>> Series applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2018-01-21 14:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 12:21 [dpdk-dev] [PATCH v1 0/3] " Ophir Munk
2017-12-17 12:21 ` [dpdk-dev] [PATCH v1 1/3] net/tap: add BPF sections for TAP device Ophir Munk
2017-12-17 12:21 ` [dpdk-dev] [PATCH v1 2/3] net/tap: add eBPF instructions Ophir Munk
2017-12-17 12:21 ` [dpdk-dev] [PATCH v1 3/3] net/tap: add eBPF classifiers map and actions Ophir Munk
2017-12-28 10:09 ` [dpdk-dev] [PATCH v2 0/2] TAP RSS eBPF cover letter Ophir Munk
2017-12-28 10:09 ` [dpdk-dev] [PATCH v2 1/2] net/tap: add eBPF instructions to TAP device Ophir Munk
2017-12-28 10:09 ` [dpdk-dev] [PATCH v2 2/2] net/tap: implement RSS with eBPF classifier and action Ophir Munk
2018-01-10 7:06 ` [dpdk-dev] [PATCH v3 0/2] TAP RSS eBPF cover letter Ophir Munk
2018-01-10 7:06 ` [dpdk-dev] [PATCH v3 1/2] net/tap: add eBPF instructions to TAP device Ophir Munk
2018-01-10 9:34 ` Pascal Mazon
2018-01-10 10:12 ` Ophir Munk
2018-01-10 7:06 ` [dpdk-dev] [PATCH v3 2/2] net/tap: implement RSS with eBPF classifier and action Ophir Munk
2018-01-10 10:19 ` Pascal Mazon
2018-01-11 17:20 ` Ophir Munk
2018-01-10 10:10 ` [dpdk-dev] [PATCH v3 0/2] TAP RSS eBPF cover letter Jason Wang
2018-01-10 15:34 ` Ophir Munk
2018-01-11 2:45 ` Jason Wang
2018-01-11 17:45 ` [dpdk-dev] [PATCH v4 0/5] " Ophir Munk
2018-01-11 17:45 ` [dpdk-dev] [PATCH v4 1/5] net/tap: support actions for different classifiers Ophir Munk
2018-01-11 17:45 ` [dpdk-dev] [PATCH v4 2/5] net/tap: add eBPF bytes code Ophir Munk
2018-01-11 17:45 ` [dpdk-dev] [PATCH v4 3/5] net/tap: add eBPF program file Ophir Munk
2018-01-11 17:45 ` [dpdk-dev] [PATCH v4 4/5] net/tap: add eBPF API Ophir Munk
2018-01-11 17:45 ` [dpdk-dev] [PATCH v4 5/5] net/tap: implement TAP RSS using eBPF Ophir Munk
2018-01-18 13:38 ` [dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter Ophir Munk
2018-01-18 13:38 ` [dpdk-dev] [PATCH v5 1/6] net/tap: support actions for different classifiers Ophir Munk
2018-01-18 13:38 ` [dpdk-dev] [PATCH v5 2/6] net/tap: add eBPF bytes code Ophir Munk
2018-01-18 13:38 ` [dpdk-dev] [PATCH v5 3/6] net/tap: add eBPF program file Ophir Munk
2018-01-18 13:38 ` [dpdk-dev] [PATCH v5 4/6] net/tap: add eBPF API Ophir Munk
2018-01-18 13:38 ` [dpdk-dev] [PATCH v5 5/6] net/tap: implement TAP RSS using eBPF Ophir Munk
2018-01-18 13:38 ` [dpdk-dev] [PATCH v5 6/6] doc: detail new tap RSS feature in guides Ophir Munk
2018-01-19 6:48 ` [dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter Pascal Mazon
2018-01-20 16:15 ` Ferruh Yigit
2018-01-20 21:25 ` Ophir Munk
2018-01-21 14:20 ` Ferruh Yigit [this message]
2018-01-20 21:11 ` [dpdk-dev] [PATCH v6 " Ophir Munk
2018-01-20 21:11 ` [dpdk-dev] [PATCH v6 1/6] net/tap: support actions for different classifiers Ophir Munk
2018-01-20 21:11 ` [dpdk-dev] [PATCH v6 2/6] net/tap: add eBPF program file Ophir Munk
2018-01-20 21:11 ` [dpdk-dev] [PATCH v6 3/6] net/tap: add eBPF bytes code Ophir Munk
2018-01-20 21:11 ` [dpdk-dev] [PATCH v6 4/6] net/tap: add eBPF API Ophir Munk
2018-01-20 21:11 ` [dpdk-dev] [PATCH v6 5/6] net/tap: implement TAP RSS using eBPF Ophir Munk
2018-01-20 21:11 ` [dpdk-dev] [PATCH v6 6/6] doc: detail new tap RSS feature in guides Ophir Munk
2018-01-21 14:50 ` [dpdk-dev] [PATCH v6 0/6] TAP RSS eBPF cover letter Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1eec0e-d6cc-2329-2a71-f735821afa1a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).