From: Dongdong Liu <liudongdong3@huawei.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, <dev@dpdk.org>,
<thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>
Cc: <stable@dpdk.org>, <lihuisong@huawei.com>
Subject: Re: [PATCH v3 2/2] net/hns3: add FDIR VLAN match mode runtime config
Date: Fri, 30 Jun 2023 09:05:22 +0800 [thread overview]
Message-ID: <1d35d8e3-1bd6-7301-eba3-e33fd35cc8a6@huawei.com> (raw)
In-Reply-To: <cf12bc7c-77e3-0cd1-a399-4b9c1f1a1499@amd.com>
Hi Ferruh
On 2023/6/29 23:52, Ferruh Yigit wrote:
> On 6/29/2023 2:21 PM, Dongdong Liu wrote:
>> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
>> index 5373ec5a8f..001ccbdb62 100644
>> --- a/doc/guides/nics/hns3.rst
>> +++ b/doc/guides/nics/hns3.rst
>> @@ -140,6 +140,32 @@ Runtime Configuration
>> For example::
>> -a 0000:7d:00.0,mbx_time_limit_ms=600
>>
>> +- ``fdir_vlan_match_mode`` (default ``strict``)
>> +
>> + Used to select VLAN match mode. This runtime config can be ``strict``
>> + or ``nostrict`` and is only valid for PF devices.
>> + If driver works on ``strict`` mode (default mode), hardware does strictly
>> + match the input flow base on VLAN number.
>> +
>> + For the following scenarios with two rules:
>> +
>> + .. code-block:: console
>> +
>> + rule0:
>> + pattern: eth type is 0x0806
>> + actions: queue index 3
>> + rule1:
>> + pattern: eth type is 0x0806 / vlan vid is 20
>> + actions: queue index 4
>> +
>> + If application select ``strict`` mode, only the ARP packets with VLAN
>> + 20 are directed to queue 4, and the ARP packets with other VLAN ID
>> + cannot be directed to the specified queue. If application want to all
>> + ARP packets with or without VLAN to be directed to the specified queue,
>> + application can select ``nostrict`` mode and just need to set rule0.
>> +
>> + For example::
>> + -a 0000:7d:00.0,fdir_vlan_match_mode=nostrict>
>
> '::' doesn't provide pre-formatted text without an empty line after it,
> I will fix this while merging, but other device argument documentations
> have same problem, can you please send a patch to fix it?
Thanks for pointing this and helping fix it.
I will send a patch to fix the remain issue.
Thanks,
Dongdong.
>
> .
>
next prev parent reply other threads:[~2023-06-30 1:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 12:43 [PATCH 0/2] " Dongdong Liu
2023-06-26 12:43 ` [PATCH 1/2] net/hns3: delete duplicate macro definition Dongdong Liu
2023-06-26 12:43 ` [PATCH 2/2] net/hns3: add FDIR VLAN match mode runtime config Dongdong Liu
2023-06-27 7:11 ` [PATCH v2 0/2] " Dongdong Liu
2023-06-27 7:11 ` [PATCH v2 1/2] net/hns3: delete duplicate macro definition Dongdong Liu
2023-06-27 7:11 ` [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config Dongdong Liu
2023-06-27 12:00 ` [PATCH v2 0/2] " Ferruh Yigit
2023-06-29 13:21 ` [PATCH v3 " Dongdong Liu
2023-06-29 13:21 ` [PATCH v3 1/2] net/hns3: delete duplicate macro definition Dongdong Liu
2023-06-29 13:21 ` [PATCH v3 2/2] net/hns3: add FDIR VLAN match mode runtime config Dongdong Liu
2023-06-29 15:52 ` Ferruh Yigit
2023-06-30 1:05 ` Dongdong Liu [this message]
2023-06-29 15:53 ` [PATCH v3 0/2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d35d8e3-1bd6-7301-eba3-e33fd35cc8a6@huawei.com \
--to=liudongdong3@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).