From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: dev@dpdk.org, "Paul Szczepanek" <paul.szczepanek@arm.com>,
"Tomáš Ďurovec" <tomas.durovec@pantheon.tech>
Subject: Re: [PATCH v2 4/7] dts: enable copying directories to and from nodes
Date: Tue, 29 Oct 2024 12:00:50 +0000 [thread overview]
Message-ID: <1dc9390f-5cec-45c9-b31e-643b06e837fa@arm.com> (raw)
In-Reply-To: <CAJvnSUCqsANFOPjj5Xgsq0mvYePRreaq6t4+qdezLEk0mEa3Pg@mail.gmail.com>
On 29/10/2024 01:07, Patrick Robb wrote:
> On Mon, Oct 21, 2024 at 9:49 AM Luca Vizzarro wrote:
> +
> + @abstractmethod
> + def remove_remote_file(self, remote_file_path: str | PurePath,
> force: bool = True) -> None:
> + """Remove remote file, by default remove forcefully.
> +
> + Args:
> + remote_file_path: The file path to remove.
> + force: If :data:`True`, ignore all warnings and try to
> remove at all costs.
> + """
>
>
> This is outside of the scope of this patch, but I figured I would
> comment that we should use this to clean the dpdk-devbind.py file when
> we re-add that functionality. I'm glad this method is added. :)
Sounds good to me!
> + @abstractmethod
> + def create_remote_tarball(
> + self,
> + remote_dir_path: str | PurePath,
> + compress_format: TarCompressionFormat =
> TarCompressionFormat.none,
> + exclude: str | list[str] | None = None,
> + ) -> PurePosixPath:
>
>
> Does this have to be a PurePosixPath instead of a PurePath? I know
> adding Windows support for DTS seems far out, but we should not add in
> barriers to that now without good reason (though if there is a strong
> practical reason why we want to do this now, then okay). I believe we
> will have a PurePosixPath return in testbed_model/posix_session.py and a
> PureWindowsPath return in testbed_model/windows_session.py (when it exists).
Excellent catch! Quite missed this, we should be able to amend this to
PurePath under os_session.py and keep PurePosixPath under posix_session.py
>
> Otherwise, I know we discussed this at the DTS call on Thurs, but thanks
> for remaining .gz .xz agnostic.
The choice to zip the tarball is taken under
framework.testbed_model.sut_node:_copy_dpdk_tree
next prev parent reply other threads:[~2024-10-29 12:00 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:01 [PATCH 0/7] DTS external DPDK build Tomáš Ďurovec
2024-09-30 16:01 ` [PATCH 1/7] dts: rename build target to " Tomáš Ďurovec
2024-09-30 16:01 ` [PATCH 2/7] dts: one dpdk build per test run Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 3/7] dts: fix remote session file transfer vars Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 4/7] dts: add the ability to copy directories via remote Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 5/7] dts: add support for externally compiled DPDK Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 6/7] doc: update argument options for external DPDK build Tomáš Ďurovec
2024-09-30 16:02 ` [PATCH 7/7] dts: remove git ref option Tomáš Ďurovec
2024-10-21 13:49 ` [PATCH v2 0/7] DTS external DPDK build Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 1/7] dts: rename build target to " Luca Vizzarro
2024-10-25 18:05 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 2/7] dts: enforce one dpdk build per test run Luca Vizzarro
2024-10-25 18:08 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 3/7] dts: fix remote session file transfer vars Luca Vizzarro
2024-10-21 13:49 ` [PATCH v2 4/7] dts: enable copying directories to and from nodes Luca Vizzarro
2024-10-25 18:12 ` Dean Marx
2024-10-29 1:07 ` Patrick Robb
2024-10-29 12:00 ` Luca Vizzarro [this message]
2024-10-21 13:49 ` [PATCH v2 5/7] dts: add support for externally compiled DPDK Luca Vizzarro
2024-10-25 18:29 ` Dean Marx
2024-10-29 11:43 ` Luca Vizzarro
2024-10-29 15:48 ` Dean Marx
2024-10-29 19:52 ` Dean Marx
2024-10-29 21:12 ` Luca Vizzarro
2024-10-29 1:19 ` Patrick Robb
2024-10-29 11:48 ` Luca Vizzarro
2024-10-29 19:59 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 6/7] doc: update argument options for external DPDK build Luca Vizzarro
2024-10-25 18:30 ` Dean Marx
2024-10-29 1:23 ` Patrick Robb
2024-10-29 12:35 ` Luca Vizzarro
2024-10-29 20:04 ` Patrick Robb
2024-10-21 13:49 ` [PATCH v2 7/7] dts: remove git ref option Luca Vizzarro
2024-10-25 18:31 ` Dean Marx
2024-10-29 1:28 ` Patrick Robb
2024-10-29 11:51 ` Luca Vizzarro
2024-10-21 22:39 ` [PATCH v2 0/7] DTS external DPDK build Dean Marx
2024-10-22 7:27 ` Paul Szczepanek
2024-10-22 14:56 ` Luca Vizzarro
2024-10-24 17:14 ` Dean Marx
2024-10-21 22:46 ` [PATCH v3 " Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 1/7] dts: rename build target to " Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 2/7] dts: enforce one dpdk build per test run Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 3/7] dts: change remote and local paths objects Luca Vizzarro
2024-10-25 18:10 ` Dean Marx
2024-10-29 1:29 ` Patrick Robb
2024-10-21 22:46 ` [PATCH v3 4/7] dts: enable copying directories to and from nodes Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 5/7] dts: add support for externally compiled DPDK Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 6/7] doc: update argument options for external DPDK build Luca Vizzarro
2024-10-21 22:46 ` [PATCH v3 7/7] dts: remove git ref option Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dc9390f-5cec-45c9-b31e-643b06e837fa@arm.com \
--to=luca.vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=tomas.durovec@pantheon.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).