From: Ferruh Yigit <ferruh.yigit@intel.com>
To: kirankumark@marvell.com,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, ajit.khaparde@broadcom.com
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: add HIGIG2 key field to flow API
Date: Fri, 18 Oct 2019 18:36:24 +0100 [thread overview]
Message-ID: <1de0ed2a-471b-b40a-ef29-76c4bc82ffc8@intel.com> (raw)
In-Reply-To: <20191018041300.22290-1-kirankumark@marvell.com>
On 10/18/2019 5:13 AM, kirankumark@marvell.com wrote:
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> Add new rte_flow_item_higig2_hdr in order to match higig2 header.
> It is a layer 2.5 protocol and used in Broadcom switches.
> Header format is based on the following document.
> http://read.pudn.com/downloads558/doc/comm/2301468/HiGig_protocol.pdf
+1 to have protocol documentation, but what is 'pudn.com'? Is it kind of
download site? Isn't there any official web site for the protocol?
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
> V5 changes:
> * Changed broadcom to Broadcom
> * Changed RTE_HIGIG2_H to RTE_HIGIG_H
> * Fixed meson build
>
> V4 Changes:
> * Removed packed attribute
>
> V3 Changes:
> * Fixed Copyright header
> * Fixed version info in the subject
>
> V2 Changes:
> * Added support in testpmd to parse the higig2 item
> * Moved the higig2 header to new file
> * Added indentation in doc
>
> app/test-pmd/cmdline_flow.c | 33 +++++++
> doc/guides/prog_guide/rte_flow.rst | 8 ++
> lib/librte_ethdev/rte_flow.c | 1 +
> lib/librte_ethdev/rte_flow.h | 7 ++
> lib/librte_net/Makefile | 2 +-
> lib/librte_net/meson.build | 3 +-
> lib/librte_net/rte_higig.h | 138 +++++++++++++++++++++++++++++
'lib/librte_net/' maintainer is Olivier, so by default new file maintainer will
be Olivier, it is good to get his ack to confirm this before merging patch.
Also can you please update "doc/api/doxy-api-index.md" to add new 'rte_higig.h'
file so that it can be part of our API documentation.
btw, 'rte_gre.h' & 'rte_mpls.h' are seems missing in API documentation, another
patch to add them would be nice if possible.
next prev parent reply other threads:[~2019-10-18 17:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 4:29 [dpdk-dev] [PATCH] " kirankumark
2019-10-14 7:08 ` Andrew Rybchenko
2019-10-15 4:23 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-15 6:20 ` [dpdk-dev] " kirankumark
2019-10-15 6:27 ` Jerin Jacob
2019-10-15 6:57 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-15 8:22 ` [dpdk-dev] " Ananyev, Konstantin
2019-10-15 8:32 ` [dpdk-dev] [PATCH v3] " kirankumark
2019-10-17 4:15 ` [dpdk-dev] [PATCH v4] " kirankumark
2019-10-17 9:08 ` Andrew Rybchenko
2019-10-18 4:13 ` [dpdk-dev] [PATCH v5] " kirankumark
2019-10-18 7:36 ` Andrew Rybchenko
2019-10-18 17:36 ` Ferruh Yigit [this message]
2019-10-19 4:51 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-19 4:56 ` [dpdk-dev] [PATCH v6] " kirankumark
2019-10-19 9:47 ` Jerin Jacob
2019-10-20 4:52 ` [dpdk-dev] [PATCH v7] " kirankumark
2019-10-20 13:56 ` Jerin Jacob
2019-10-21 3:52 ` [dpdk-dev] [PATCH v8] " kirankumark
2019-10-21 9:16 ` [dpdk-dev] [PATCH v9] " kirankumark
2019-10-21 16:48 ` Olivier Matz
2019-10-22 4:16 ` [dpdk-dev] [PATCH v10] " kirankumark
2019-10-22 9:19 ` Ferruh Yigit
2019-10-23 10:50 ` Raslan Darawsheh
2019-10-23 11:39 ` Olivier Matz
2019-10-23 11:43 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-23 14:04 ` Olivier Matz
2019-10-23 14:14 ` Ferruh Yigit
2019-10-23 22:04 ` [dpdk-dev] " Thomas Monjalon
2019-10-15 16:47 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2019-10-16 3:14 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de0ed2a-471b-b40a-ef29-76c4bc82ffc8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=kirankumark@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).