From: Matej Vido <vido@cesnet.cz>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/szedata2: fix incorrect device memory access
Date: Tue, 24 Jan 2017 16:55:38 +0100 [thread overview]
Message-ID: <1e1906b4-6ee5-ecc0-019e-28f0689c4d76@cesnet.cz> (raw)
In-Reply-To: <f8fb64a6-bccb-bb70-9098-3c214754cd88@intel.com>
On 24.01.2017 16:11, Ferruh Yigit wrote:
> On 1/24/2017 2:02 PM, Matej Vido wrote:
>> On 24.01.2017 12:58, Ferruh Yigit wrote:
>>> On 1/24/2017 10:49 AM, Matej Vido wrote:
>>>> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>>>>
>>>> Signed-off-by: Matej Vido <vido@cesnet.cz>
>>> Unrelated from this patch, in maintainers file, you have your other mail
>>> address: "Matej Vido <matejvido@gmail.com>", do you want to update it?
>> Hi Ferruh,
>>
>> yes, I will send the patch.
>>>> ---
>>>> drivers/net/szedata2/rte_eth_szedata2.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/szedata2/rte_eth_szedata2.h b/drivers/net/szedata2/rte_eth_szedata2.h
>>>> index b58adb6..afe8a38 100644
>>>> --- a/drivers/net/szedata2/rte_eth_szedata2.h
>>>> +++ b/drivers/net/szedata2/rte_eth_szedata2.h
>>>> @@ -192,7 +192,7 @@ struct szedata {
>>>> }
>>>>
>>>> #define SZEDATA2_PCI_RESOURCE_PTR(rsc, offset, type) \
>>>> - ((type)((uint8_t *)(rsc)->addr) + (offset))
>>>> + ((type)(((uint8_t *)(rsc)->addr) + (offset)))
>>> Although output will be same, (in all uses, type is a pointer),
> Of course won't be same, please forget about it J, I am confused.
>
> So these two differs a lot, taking into account that offset numbers used
> are big numbers (0x8000..), it should be accessing very unrelated addresses.
>
> So how this was working before?
The macro was fine before the patch [1]. It hasn't been working since
the acceptance of that patch, but I didn't manage to test the
functionality until now.
[1] http://dpdk.org/ml/archives/dev/2016-December/053241.html
Regards,
Matej
>
>> this
>>> seems the intention, so:
>>>
>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>
>>> btw, following will do same, right, not sure if it is better:
>>> ((type)(rsc)->addr + (offset))
>> This is also wrong. The intention of the macro is to add an offset to
>> the base address and typecast the result.
>>
>> Regards,
>> Matej
>>>>
>>>> enum szedata2_link_speed {
>>>> SZEDATA2_LINK_SPEED_DEFAULT = 0,
>>>>
next prev parent reply other threads:[~2017-01-24 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 10:49 Matej Vido
2017-01-24 11:58 ` Ferruh Yigit
2017-01-24 14:02 ` Matej Vido
2017-01-24 14:17 ` Ferruh Yigit
2017-01-24 15:11 ` Ferruh Yigit
2017-01-24 15:55 ` Matej Vido [this message]
2017-01-24 16:03 ` Ferruh Yigit
2017-01-24 15:24 ` Ferruh Yigit
2017-01-24 16:05 ` Matej Vido
2017-01-24 16:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1906b4-6ee5-ecc0-019e-28f0689c4d76@cesnet.cz \
--to=vido@cesnet.cz \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).