From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org
Cc: Ilya Maximets <i.maximets@ovn.org>
Subject: Re: [dpdk-dev] [RFC PATCH] log: track log level changes
Date: Thu, 9 Jul 2020 02:16:27 +0200 [thread overview]
Message-ID: <1f3ca39a-1814-0b3a-39d2-445056a0352e@partner.samsung.com> (raw)
In-Reply-To: <bfdc7fa2-e78e-5e7e-2be1-a868f7fb8c7b@solarflare.com>
W dniu 26.06.2020 o 16:46, Andrew Rybchenko pisze:
> On 6/26/20 2:47 PM, David Marchand wrote:
>> Add a log message when changing log levels to be sure of which logtype
>> is enabled.
>>
>> Suggested-by: Ilya Maximets <i.maximets@ovn.org>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
I also like the idea so:
Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
although I think there is one place that can be smoothed a bit. Every
newly registered type's loglevel is set to RTE_LOG_INFO in
__rte_log_register(), so:
* if new type is registered with rte_log_register_type_and_pick_level()
and level is set to INFO, nothing will be printed (as current is equal
to new level);
* any registration made with rte_log_register() won't be seen either as
there is no call to newly introduced function logtype_set_level().
How about additionally changing behavior so any registration will print
change from "disabled" (level=0) to new level:
* in case of rte_log_register_type_and_pick_level() to chosen level
* in case of rte_log_register() to default level which is "info"
Best regards
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com
next prev parent reply other threads:[~2020-07-09 0:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 11:47 David Marchand
2020-06-26 14:46 ` Andrew Rybchenko
2020-07-09 0:16 ` Lukasz Wojciechowski [this message]
2021-03-23 8:19 ` David Marchand
2021-03-23 10:19 ` [dpdk-dev] [PATCH 0/3] Track " David Marchand
2021-03-23 10:19 ` [dpdk-dev] [PATCH 1/3] test/log: check levels David Marchand
2021-03-23 10:19 ` [dpdk-dev] [PATCH 2/3] log: track log level changes David Marchand
2021-03-23 10:19 ` [dpdk-dev] [PATCH 3/3] eal: fix evaluation of log level option David Marchand
2021-03-23 15:54 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-03-24 9:45 ` Lukasz Wojciechowski
2021-03-24 10:32 ` [dpdk-dev] [PATCH v2 0/3] Track log level changes David Marchand
2021-03-24 10:32 ` [dpdk-dev] [PATCH v2 1/3] test/log: check levels David Marchand
2021-03-24 10:32 ` [dpdk-dev] [PATCH v2 2/3] log: track log level changes David Marchand
2021-04-08 15:54 ` Thomas Monjalon
2021-04-09 9:08 ` David Marchand
2021-04-09 9:12 ` Thomas Monjalon
2021-03-24 10:32 ` [dpdk-dev] [PATCH v2 3/3] eal: fix evaluation of log level option David Marchand
2021-04-09 11:04 ` [dpdk-dev] [PATCH v3 0/3] Track log level changes David Marchand
2021-04-09 11:04 ` [dpdk-dev] [PATCH v3 1/3] test/log: check levels David Marchand
2021-04-09 11:04 ` [dpdk-dev] [PATCH v3 2/3] log: track log level changes David Marchand
2021-04-09 11:59 ` Thomas Monjalon
2021-04-09 12:14 ` David Marchand
2021-04-09 11:04 ` [dpdk-dev] [PATCH v3 3/3] eal: fix evaluation of log level option David Marchand
2021-04-09 12:21 ` [dpdk-dev] [PATCH v3 0/3] Track log level changes David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f3ca39a-1814-0b3a-39d2-445056a0352e@partner.samsung.com \
--to=l.wojciechow@partner.samsung.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=i.maximets@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).