DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset
Date: Fri, 20 Jan 2017 11:20:06 +0100	[thread overview]
Message-ID: <2005966.sVKUI0LeEs@xps13> (raw)
In-Reply-To: <1484899493-11051-1-git-send-email-yuanhan.liu@linux.intel.com>

2017-01-20 16:04, Yuanhan Liu:
> Fix an silly error by auto-complete while managing the merge conflicts.
> It's the eth_dev_data (but not eth_dev) entry should be memset.
> 
> Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model")

You should describe the impact on this bug.
It will be helpful for those testing the RC1.

> -	memset(&rte_eth_devices[port_id], 0, sizeof(*eth_dev->data));
> +	memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data));

The title should be contain the scope of the bug.
I suggest "fix data reset when allocating port".

  reply	other threads:[~2017-01-20 10:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20  8:04 Yuanhan Liu
2017-01-20 10:20 ` Thomas Monjalon [this message]
2017-01-20 10:34   ` Yuanhan Liu
2017-01-20 11:09     ` Ferruh Yigit
2017-01-20 18:05     ` Thomas Monjalon
2017-01-20 11:21 ` Ferruh Yigit
2017-01-20 15:27   ` Ferruh Yigit
2017-01-22  2:45     ` Yuanhan Liu
2017-01-23  9:41       ` Ferruh Yigit
2017-01-23 10:34         ` Yuanhan Liu
2017-01-23 11:05           ` Ferruh Yigit
2017-01-23 11:24             ` Yuanhan Liu
2017-01-23 11:32               ` Ferruh Yigit
2017-01-23 11:40                 ` Yuanhan Liu
2017-01-23 11:56                   ` Yuanhan Liu
2017-01-23 12:44                     ` Ananyev, Konstantin
2017-01-23 12:52                       ` Yuanhan Liu
2017-01-23 13:06                         ` Ananyev, Konstantin
2017-01-23 13:09                           ` Ferruh Yigit
2017-01-25 11:16                           ` Thomas Monjalon
2017-01-28 13:14                             ` Yuanhan Liu
2017-01-30 11:07                               ` Remy Horton
2017-01-24  8:29                     ` Remy Horton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2005966.sVKUI0LeEs@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).