From: Bruce Richardson <bruce.richardson@intel.com>
To: reshmapa <reshma.pattan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] distributor_app: new sample application for distributor library
Date: Tue, 23 Sep 2014 13:55:10 +0100 [thread overview]
Message-ID: <20140923125510.GB14152@BRICHA3-MOBL> (raw)
In-Reply-To: <1410869607-16842-1-git-send-email-reshma.pattan@intel.com>
On Tue, Sep 16, 2014 at 01:13:24PM +0100, reshmapa wrote:
> From: Reshma Pattan <reshma.pattan@intel.com>
>
> A new sample app that shows the usage of the distributor library. This
> app works as follows:
>
> *An RX thread runs which pulls packets from each ethernet port in turn
> and passes those packets to worker using a distributor component.
>
> *The workers take the packets in turn, and determine the output port
> for those packets using basic l2forwarding doing an xor on the source
> port id.
>
> *The RX thread takes the returned packets from the workers and enqueue
> those packets into an rte_ring structure.
>
> *A TX thread pulls the packets off the rte_ring structure and then
> sends each packet out the output port specified previously by the worker
>
> Bruce Richardson (1):
> distributor_app: new sample app
>
> Reshma Pattan (2):
> distributor_app: code review comments implementation
> distributor_app: removed extra spaces
>
Since this is just a sample app and the second two patches are just minor
adjustments to it, I suggest that this be resubmitted as a single patch
instead of a set. That should also fix the whitespace warnings one gets when
using "git am" to apply the set.
Please also check the indentation used in the file. I see in a number of
places that spaces are used instead of tabs for indentation. Running
checkpatch.pl on the patch before submission should help catch these issues.
Regards,
/Bruce
> examples/Makefile | 1 +
> examples/distributor_app/Makefile | 57 ++++
> examples/distributor_app/main.c | 586 ++++++++++++++++++++++++++++++++++++++
> examples/distributor_app/main.h | 46 +++
> 4 files changed, 690 insertions(+)
> create mode 100644 examples/distributor_app/Makefile
> create mode 100644 examples/distributor_app/main.c
> create mode 100644 examples/distributor_app/main.h
>
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2014-09-23 12:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 12:13 reshmapa
2014-09-16 12:13 ` [dpdk-dev] [PATCH 1/3] distributor_app: new sample app reshmapa
2014-09-16 12:13 ` [dpdk-dev] [PATCH 2/3] distributor_app: code review comments implementation reshmapa
2014-09-16 12:13 ` [dpdk-dev] [PATCH 3/3] distributor_app: removed extra spaces reshmapa
2014-09-23 12:55 ` Bruce Richardson [this message]
2014-09-24 14:16 ` [dpdk-dev] [PATCH v2] distributor_app: new sample app reshmapa
2014-09-26 15:11 ` De Lara Guarch, Pablo
2014-09-26 15:51 ` Ananyev, Konstantin
2014-09-29 12:39 ` Pattan, Reshma
2014-09-29 13:06 ` Ananyev, Konstantin
2014-09-29 13:35 ` De Lara Guarch, Pablo
2014-09-29 14:35 ` Neil Horman
2014-09-30 8:02 ` Pattan, Reshma
2014-09-30 9:21 ` Ananyev, Konstantin
2014-09-30 10:39 ` [dpdk-dev] [PATCH v3] " reshmapa
2014-09-30 11:34 ` Neil Horman
2014-09-30 12:18 ` Bruce Richardson
2014-09-30 13:39 ` Neil Horman
2014-10-01 14:47 ` Pattan, Reshma
2014-10-01 14:56 ` Neil Horman
2014-10-01 15:37 ` Bruce Richardson
2014-10-01 16:07 ` Neil Horman
2014-10-06 14:16 ` Pattan, Reshma
2014-10-06 14:44 ` Neil Horman
2014-10-06 17:34 ` Pattan, Reshma
2014-10-06 19:02 ` Neil Horman
2014-10-02 9:04 ` Ananyev, Konstantin
2014-10-01 13:33 ` [dpdk-dev] [PATCH v4] distributor_app: gracefull shutdown of tx/rx threads on SIGINT reshmapa
2014-10-01 13:46 ` Pattan, Reshma
2014-10-01 13:49 ` Thomas Monjalon
2014-10-01 14:33 ` [dpdk-dev] [PATCH v5] distributor_app: new sample app reshmapa
2014-10-17 13:59 ` [dpdk-dev] [PATCH v6] " Reshma Pattan
2014-11-02 20:08 ` De Lara Guarch, Pablo
2014-11-03 15:49 ` [dpdk-dev] [PATCH v7] " Reshma Pattan
2014-11-03 16:03 ` De Lara Guarch, Pablo
2014-11-13 21:30 ` Thomas Monjalon
2014-11-14 8:44 ` Pattan, Reshma
2014-11-16 21:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923125510.GB14152@BRICHA3-MOBL \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).