From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask
Date: Thu, 4 Dec 2014 14:25:30 +0000 [thread overview]
Message-ID: <20141204142529.GB4828@bricha3-MOBL3> (raw)
In-Reply-To: <1417703013-32480-1-git-send-email-bruce.richardson@intel.com>
On Thu, Dec 04, 2014 at 02:23:33PM +0000, Bruce Richardson wrote:
> Hi Cristian, please review before I send out publically. Thanks. B.
> -------------------------
>
> When a lookup was done on a table_array structure with an incomplete
> bitmask, the results was always zero hits. This was because the
> pkts_mask value was cleared as we process each entry, and the result
> was assigned at the end of the loop, when pkts_mask was zero.
> Changing the assignment to occur at the start, before the pkts_mask
> gets cleared, fixes this issue.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Self-nak on this copy, please see follow-on without the review request to Cristian
(who can hopefully ack this soon :-) )
> ---
> lib/librte_table/rte_table_array.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_table/rte_table_array.c b/lib/librte_table/rte_table_array.c
> index 0b1d42a..4d3c05e 100644
> --- a/lib/librte_table/rte_table_array.c
> +++ b/lib/librte_table/rte_table_array.c
> @@ -164,6 +164,8 @@ rte_table_array_lookup(
> {
> struct rte_table_array *t = (struct rte_table_array *) table;
>
> + *lookup_hit_mask = pkts_mask;
> +
> if ((pkts_mask & (pkts_mask + 1)) == 0) {
> uint64_t n_pkts = __builtin_popcountll(pkts_mask);
> uint32_t i;
> @@ -190,8 +192,6 @@ rte_table_array_lookup(
> }
> }
>
> - *lookup_hit_mask = pkts_mask;
> -
> return 0;
> }
>
> --
> 1.9.3
>
next prev parent reply other threads:[~2014-12-04 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 14:23 Bruce Richardson
2014-12-04 14:25 ` Bruce Richardson [this message]
2014-12-04 14:24 Bruce Richardson
2014-12-04 15:23 ` Dumitrescu, Cristian
2014-12-05 16:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204142529.GB4828@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).