DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Marvin Liu <yong.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fix bug can not build example application for missing link library
Date: Wed, 17 Dec 2014 10:47:49 +0000	[thread overview]
Message-ID: <20141217104748.GD9184@bricha3-MOBL3> (raw)
In-Reply-To: <1418808044-18540-1-git-send-email-yong.liu@intel.com>

On Wed, Dec 17, 2014 at 05:20:44PM +0800, Marvin Liu wrote:
> From: Yong Liu <yong.liu@intel.com>
> 
> main.o: In function `rte_pktmbuf_free':
> main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id'
> 
> Signed-off-by: Marvin liu <yong.liu@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  mk/rte.app.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 5fc3118..b51d814 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -61,7 +61,7 @@ ifeq ($(NO_AUTOLIBS),)
>  
>  LDLIBS += --whole-archive
>  
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>  
>  ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
>  LDLIBS += -lrte_distributor
> @@ -129,7 +129,7 @@ endif
>  
>  LDLIBS += --start-group
>  
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),n)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>  
>  ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y)
>  LDLIBS += -lrte_kvargs
> @@ -251,7 +251,7 @@ build: _postbuild
>  
>  exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
>  
> -ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
>  LDLIBS += -l$(RTE_LIBNAME)
>  endif
>  
> -- 
> 1.9.3
> 

  reply	other threads:[~2014-12-17 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17  9:20 Marvin Liu
2014-12-17 10:47 ` Bruce Richardson [this message]
2014-12-17 11:00   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141217104748.GD9184@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).