From: Bruce Richardson <bruce.richardson@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5
Date: Wed, 17 Dec 2014 14:08:27 +0000 [thread overview]
Message-ID: <20141217140826.GE9184@bricha3-MOBL3> (raw)
In-Reply-To: <1418820925-20318-1-git-send-email-olivier.matz@6wind.com>
On Wed, Dec 17, 2014 at 01:55:20PM +0100, Olivier Matz wrote:
> This series are compilation fixes seen with clang-3.5 on linux.
>
> Olivier Matz (5):
> test-devargs: fix misplaced braces in strncmp call
> examples/l3fwd: fix compilation with clang 3.5
> examples/netmap: fix overflow in ioctl operation
> examples/vm_power_manager: move -lvirt in LDLIBS
> examples/vm_power_manager: fix initialization of cmdline token
>
> app/test/test_devargs.c | 2 +-
> examples/l3fwd/main.c | 4 +++-
> examples/netmap_compat/lib/compat_netmap.c | 2 +-
> examples/netmap_compat/lib/compat_netmap.h | 2 +-
> examples/vm_power_manager/Makefile | 4 +++-
> examples/vm_power_manager/vm_power_cli.c | 2 +-
> 6 files changed, 10 insertions(+), 6 deletions(-)
>
> --
> 2.1.3
>
Interesting. I've just upgraded to Fedora 21, and I'm getting a lot of other,
different errors on compilation using its version of clang (3.4.2). Patches soon
to follow, but I'm surprised that they don't show up in clang 3.5. Perhaps they
are just compiler bugs in the Fedora version.
Examples of the errors are shown below.
/Bruce
CC cmdline_rdline.o
/home/bruce/dpdk.org/lib/librte_cmdline/cmdline_rdline.c:249:27: fatal error: equality comparison with extraneous parentheses [-Wparentheses-equality]
if (((&rdl->left)->len == 0))
~~~~~~~~~~~~~~~~~~^~~~
/home/bruce/dpdk.org/lib/librte_cmdline/cmdline_rdline.c:249:27: note: remove extraneous parentheses around the comparison to silence this warning
if (((&rdl->left)->len == 0))
~ ^ ~
/home/bruce/dpdk.org/lib/librte_cmdline/cmdline_rdline.c:249:27: note: use '=' to turn this equality comparison into an assignment
if (((&rdl->left)->len == 0))
^~
=
1 error generated.
CC eal.o
clang: fatal error: argument unused during compilation: '-I /home/bruce/dpdk.org/x86_64-native-linuxap
/home/bruce/dpdk.org/mk/internal/rte.compile-pre.mk:126: recipe for target 'eal.o' failed
gmake[7]: *** [eal.o] Error 1
next prev parent reply other threads:[~2014-12-17 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 12:55 Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 1/5] test-devargs: fix misplaced braces in strncmp call Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 2/5] examples/l3fwd: fix compilation with clang 3.5 Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 3/5] examples/netmap: fix overflow in ioctl operation Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 4/5] examples/vm_power_manager: move -lvirt in LDLIBS Olivier Matz
2014-12-17 12:55 ` [dpdk-dev] [PATCH 5/5] examples/vm_power_manager: fix initialization of cmdline token Olivier Matz
2014-12-17 14:08 ` Bruce Richardson [this message]
2014-12-17 14:24 ` [dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5 Bruce Richardson
2014-12-19 18:00 ` Bruce Richardson
2014-12-17 23:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217140826.GE9184@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).