From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call
Date: Thu, 18 Dec 2014 06:25:23 -0500 [thread overview]
Message-ID: <20141218112523.GA18008@hmsreliant.think-freely.org> (raw)
In-Reply-To: <2522675.0gKbYfjInz@xps13>
On Wed, Dec 17, 2014 at 11:20:26PM +0100, Thomas Monjalon wrote:
> Hi Neil,
>
> 2014-12-17 12:03, Neil Horman:
> > Back in:
> >
> > commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db
> > Author: Alan Carew <alan.carew@intel.com>
> > Date: Fri Dec 5 15:19:07 2014 +0100
> >
> > cmdline: fix overflow on bsd
> >
> > The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This
> > patch makes the needed correction to avoid a build break
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > CC: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> What is the meaning of CC here?
>
CC is a tag that git send-email understands. As it implies it cc's the post to
the indicated email, and records that fact in the body of the commit.
> > --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> > +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c
> > @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict,
> > if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM,
> > sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) {
> > if (cmdline_parse_etheraddr(NULL,
> > - pair[1],
> > - &dict->addr) < 0) {
> > + pair[1],
> > + &dict->addr,
> > + sizeof(struct ether_addr)) < 0) {
>
> Why not sizeof(dict->addr)?
>
Because addr is a struct ether_addr, and I always get confused when doing sizeof
on pointer variables, so I find it more clear to specify the type exactly. I'm
not bound to it though so if you like I can change it, though given its release
day, I figure you want to fix this build break asap.
Neil
> --
> Thomas
>
next prev parent reply other threads:[~2014-12-18 11:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 17:03 Neil Horman
2014-12-17 22:20 ` Thomas Monjalon
2014-12-18 11:25 ` Neil Horman [this message]
2014-12-18 12:21 ` Thomas Monjalon
2014-12-18 19:57 ` Neil Horman
2014-12-18 13:51 ` Qiu, Michael
2014-12-18 19:58 ` Neil Horman
2014-12-18 3:40 ` Cao, Waterman
2014-12-18 11:26 ` Neil Horman
2014-12-18 8:40 ` Olivier MATZ
2014-12-18 9:26 ` Olivier MATZ
2014-12-18 11:31 ` [dpdk-dev] [PATCH v2] " Neil Horman
2014-12-18 13:45 ` Qiu, Michael
2014-12-18 20:54 ` Neil Horman
2014-12-19 5:02 ` Qiu, Michael
2014-12-18 22:13 ` Thomas Monjalon
2014-12-18 16:17 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2014-12-18 16:40 ` Thomas Monjalon
2014-12-18 20:57 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218112523.GA18008@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).