From: Bruce Richardson <bruce.richardson@intel.com>
To: Ravi Kerur <rkerur@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] Fix checkpatch errors
Date: Mon, 5 Jan 2015 12:11:16 +0000 [thread overview]
Message-ID: <20150105121115.GF13152@bricha3-MOBL3> (raw)
In-Reply-To: <1419521508-31883-1-git-send-email-rkerur@gmail.com>
On Thu, Dec 25, 2014 at 10:31:46AM -0500, Ravi Kerur wrote:
> checkpatch script is run against files in librte_acl and
> librte_mempool files. No functionality change.
> Changes are tested in Ubuntu and FreeBSD.
>
> Ravi Kerur (2):
> Fix checkpatch errors in librte_acl
> Fix checkpatch errors in librte_mempool
>
There are quite a lot of changes in these patches for fixing style errors. While
you do call out what errors are treated as false positives, i.e. are not fixed,
I think the description also needs to call out what the main errors were that were
fixed, so that we can understand better why each chunk of code change was made.
Regards,
/Bruce
prev parent reply other threads:[~2015-01-05 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 15:31 Ravi Kerur
2014-12-25 15:31 ` [dpdk-dev] [PATCH 1/2] Fix checkpatch errors in librte_acl Ravi Kerur
2015-01-05 12:08 ` Bruce Richardson
2014-12-25 15:31 ` [dpdk-dev] [PATCH 2/2] Fix checkpatch errors in librte_mempool Ravi Kerur
2015-01-05 12:11 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105121115.GF13152@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).