From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] devargs: remove limit on parameters length
Date: Wed, 7 Jan 2015 14:59:00 -0800 [thread overview]
Message-ID: <20150107145900.2a139ee6@urahara> (raw)
In-Reply-To: <1420635809-30976-3-git-send-email-david.marchand@6wind.com>
On Wed, 7 Jan 2015 14:03:29 +0100
David Marchand <david.marchand@6wind.com> wrote:
> + buf = strdup(devargs_str);
> + if (buf == NULL) {
> + RTE_LOG(ERR, EAL, "cannot allocate temp memory for devargs\n");
> + goto fail;
> + }
> +
If string is only used in same function you might consider using strdupa() which avoids
worrying about freeing in error paths.
next prev parent reply other threads:[~2015-01-07 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 13:03 [dpdk-dev] [PATCH 0/2] remove limit on devargs " David Marchand
2015-01-07 13:03 ` [dpdk-dev] [PATCH 1/2] devargs: indent and cleanup David Marchand
2015-01-07 13:03 ` [dpdk-dev] [PATCH 2/2] devargs: remove limit on parameters length David Marchand
2015-01-07 22:59 ` Stephen Hemminger [this message]
2015-01-08 8:19 ` David Marchand
2015-01-08 9:15 ` Panu Matilainen
2015-02-13 15:03 ` [dpdk-dev] [PATCH v2 0/3] remove limit on devargs " David Marchand
2015-02-13 15:03 ` [dpdk-dev] [PATCH v2 1/3] devargs: indent and cleanup David Marchand
2015-02-13 15:03 ` [dpdk-dev] [PATCH v2 2/3] devargs: remove limit on parameters length David Marchand
2015-02-13 15:03 ` [dpdk-dev] [PATCH v2 3/3] app/test: fix devargs tests David Marchand
2015-02-18 12:44 ` [dpdk-dev] [PATCH v2 0/3] remove limit on devargs parameters length Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107145900.2a139ee6@urahara \
--to=stephen@networkplumber.org \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).