From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@Brocade.com>
Subject: Re: [dpdk-dev] [PATCH 0/4] Broadcom 10G NIC Poll Mode Driver
Date: Thu, 12 Feb 2015 16:45:50 -0500 [thread overview]
Message-ID: <20150212164550.0a2b8e2a@uryu.home.lan> (raw)
In-Reply-To: <0a8c8ae93e354bf0a74dd8ade9d1cc70@BRMWP-EXMB11.corp.brocade.com>
On Thu, 12 Feb 2015 14:56:06 +0000
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2015-02-12 06:33, Stephen Hemminger:
> > On Thu, 12 Feb 2015 15:00:13 +0100
> > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> >
> > > Hi Stephen,
> > >
> > > 2015-02-07 07:15, Stephen Hemminger:
> > > > Source was from FreeBSD.
> > > >
> > > > changes were to make it work and lots of de-uglification.
> > >
> > > Maintenance would be eased by showing this work with separate commits.
> > > You should at least have a patch for importing FreeBSD source without
> > > modifications.
> > >
> > > Other comment: there could be other drivers for Broadcom devices.
> > > Why not keeping the name bnx2x?
> > >
> > > Thanks
> >
> > That history is lost.
>
> I don't understand your answer,
> and you forgot one question.
> Please reply below each question.
>
> I said: "You should at least have a patch for importing FreeBSD source
> without modfications". Is the initial FreeBSD source lost?
>
> Do you agree to rename to bnx2x?
This was based of driver called bxe in FreeBsd but the
changes are so massive that there is no point in creating such a
patch except to keep some lawyer happy.
37 files changed, 33668 insertions(+), 159047 deletions(-)
It might be okay to rename the visible config option and directory
to bxe but not going to change internal things.
next prev parent reply other threads:[~2015-02-12 21:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 18:36 Stephen Hemminger
2015-02-06 18:36 ` [dpdk-dev] [PATCH 1/4] pci: allow access to PCI config space Stephen Hemminger
2015-02-09 9:45 ` David Marchand
2015-02-10 23:49 ` Stephen Hemminger
[not found] ` <c058fdefd5564f3f96bd21593c9ea19a@BRMWP-EXMB11.corp.brocade.com>
2015-02-11 1:23 ` Stephen Hemminger
2015-02-06 18:36 ` [dpdk-dev] [PATCH 2/4] bcm: add BCM pci device ids Stephen Hemminger
2015-02-06 18:36 ` [dpdk-dev] [PATCH 3/4] bcm: new poll mode driver Stephen Hemminger
2015-02-06 18:36 ` [dpdk-dev] [PATCH 4/4] bcm: enable BCM poll mode driver in config Stephen Hemminger
2015-02-07 9:15 ` [dpdk-dev] [PATCH 0/4] Broadcom 10G NIC Poll Mode Driver Jun Xiao
2015-02-07 15:15 ` Stephen Hemminger
2015-02-07 16:05 ` Jun Xiao
2015-02-07 22:23 ` Stephen Hemminger
2015-02-12 14:00 ` Thomas Monjalon
2015-02-12 14:33 ` Stephen Hemminger
2015-02-12 14:56 ` Thomas Monjalon
[not found] ` <0a8c8ae93e354bf0a74dd8ade9d1cc70@BRMWP-EXMB11.corp.brocade.com>
2015-02-12 21:45 ` Stephen Hemminger [this message]
2015-02-13 8:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212164550.0a2b8e2a@uryu.home.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=shemming@Brocade.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).