From: Neil Horman <nhorman@tuxdriver.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] xen: net-front poll mode driver
Date: Sat, 14 Feb 2015 14:31:59 -0500 [thread overview]
Message-ID: <20150214193159.GB15594@neilslaptop.think-freely.org> (raw)
In-Reply-To: <1423937208-2063-4-git-send-email-shemming@brocade.com>
On Sat, Feb 14, 2015 at 01:06:48PM -0500, Stephen Hemminger wrote:
> This driver implements DPDK driver that has the same functionality
> as net-front driver in Linux kernel.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> config/common_linuxapp | 6 +
> lib/Makefile | 1 +
> lib/librte_eal/common/eal_private.h | 7 +
> lib/librte_eal/linuxapp/eal/eal.c | 8 +
> lib/librte_pmd_xen/Makefile | 30 ++
> lib/librte_pmd_xen/virt_dev.c | 400 +++++++++++++++++++++++++
> lib/librte_pmd_xen/virt_dev.h | 30 ++
> lib/librte_pmd_xen/xen_adapter_info.h | 64 ++++
> lib/librte_pmd_xen/xen_dev.c | 369 +++++++++++++++++++++++
> lib/librte_pmd_xen/xen_dev.h | 96 ++++++
> lib/librte_pmd_xen/xen_logs.h | 23 ++
> lib/librte_pmd_xen/xen_rxtx.c | 546 ++++++++++++++++++++++++++++++++++
> lib/librte_pmd_xen/xen_rxtx.h | 110 +++++++
> mk/rte.app.mk | 4 +
> 14 files changed, 1694 insertions(+)
> create mode 100644 lib/librte_pmd_xen/Makefile
> create mode 100644 lib/librte_pmd_xen/virt_dev.c
> create mode 100644 lib/librte_pmd_xen/virt_dev.h
> create mode 100644 lib/librte_pmd_xen/xen_adapter_info.h
> create mode 100644 lib/librte_pmd_xen/xen_dev.c
> create mode 100644 lib/librte_pmd_xen/xen_dev.h
> create mode 100644 lib/librte_pmd_xen/xen_logs.h
> create mode 100644 lib/librte_pmd_xen/xen_rxtx.c
> create mode 100644 lib/librte_pmd_xen/xen_rxtx.h
><snip>
> +
> +int
> +rte_xen_pmd_init(void)
> +{
> + PMD_INIT_FUNC_TRACE();
> +
> + xen_evt_fd = open("/dev/"XEN_PMD_UIO_NAME, O_RDWR);
> +
> + if (xen_evt_fd == -1) {
> + if (errno != ENOENT)
> + PMD_INIT_LOG(ERR, "cannot open event device %s",
> + "/dev/"XEN_PMD_UIO_NAME);
> + return 0;
> + }
> +
> + return virt_eth_driver_register(&rte_xen_pmd);
> +}
It looks like you've created a new method of registering a pmd here? Why not
use the existing REGISTER_PMD_DRIVER macro? It seems like this method will
break the DSO build.
Neil
>
next prev parent reply other threads:[~2015-02-14 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 18:06 [dpdk-dev] [PATCH 1/4] xen: allow choosing dom0 support at runtime Stephen Hemminger
2015-02-14 18:06 ` [dpdk-dev] [PATCH 2/4] xen: add phys-addr command line argument Stephen Hemminger
2015-02-14 18:06 ` [dpdk-dev] [PATCH 3/4] xen: add uio driver Stephen Hemminger
2015-02-14 18:06 ` [dpdk-dev] [PATCH 4/4] xen: net-front poll mode driver Stephen Hemminger
2015-02-14 19:31 ` Neil Horman [this message]
2015-02-14 19:25 ` [dpdk-dev] [PATCH 1/4] xen: allow choosing dom0 support at runtime Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150214193159.GB15594@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).