DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout
Date: Fri, 20 Feb 2015 18:15:40 -0800	[thread overview]
Message-ID: <20150220181540.3b97dc86@urahara> (raw)
In-Reply-To: <9190554.3JBlDK3N1R@xps13>

On Fri, 20 Feb 2015 13:15:38 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-02-12 17:18, Panu Matilainen:
> > Add RTE_DEVEL_BUILD make-variable which can be used to do things
> > differently when doing development vs building a release,
> > autodetected from source root .git presence and overridable via
> > commandline. Use it to only enable -Werror compiler flag when
> > building a git checkout:
> > 
> > Failing build on warnings is a useful developer tool but its bad
> > for release tarballs which can and do get built with newer
> > compilers than what was used/available during development. Compilers
> > routinely add new warnings so code which built silently with cc X
> > might no longer do so with X+1. This doesn't make the existing code
> > any more buggier and failing the build in this case does not help
> > not help improve code quality of an already released version either.
> 
> Please, could you update documentation to explain RTE_DEVEL_BUILD option?
> Some users could try to build from git, so we should advise to disable RTE_DEVEL_BUILD.
> These files might be updated:
> 	http://dpdk.org/browse/dpdk/tree/doc/build-sdk-quick.txt
> 	http://dpdk.org/browse/dpdk/tree/doc/guides/linux_gsg/build_dpdk.rst
> 	http://dpdk.org/browse/dpdk/tree/doc/guides/freebsd_gsg/build_dpdk.rst
> 	http://dpdk.org/browse/dpdk/tree/doc/guides/prog_guide/dev_kit_build_system.rst
> 
> Thanks

Also do not allow any patches to into upstream that cause
new warnings with latest stable version of Gcc or Clang?
I don't want a clean project to get littered with warning graffiti.
Maybe a build bot?

  reply	other threads:[~2015-02-21  2:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 11:13 [dpdk-dev] [PATCH] Make -Werror optional Panu Matilainen
2015-02-12 11:25 ` Bruce Richardson
2015-02-12 12:02   ` Panu Matilainen
2015-02-12 12:08     ` Bruce Richardson
2015-02-12 13:58       ` Panu Matilainen
2015-02-12 14:02         ` Bruce Richardson
2015-02-12 14:05         ` Thomas Monjalon
2015-02-12 15:18         ` [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout Panu Matilainen
2015-02-20 12:15           ` Thomas Monjalon
2015-02-21  2:15             ` Stephen Hemminger [this message]
2015-02-21 10:48               ` Thomas Monjalon
2016-03-02 14:22             ` [dpdk-dev] [PATCH v3] mk: stop on warning only in developer build Thomas Monjalon
2016-03-02 22:04               ` Bruce Richardson
2016-03-03 10:36                 ` Thomas Monjalon
2016-03-03 10:53                   ` Panu Matilainen
2015-02-12 14:38 ` [dpdk-dev] [PATCH] Make -Werror optional Stephen Hemminger
2015-02-12 14:54   ` Panu Matilainen
2015-02-21  1:55     ` Stephen Hemminger
2015-02-21 19:33       ` Neil Horman
2015-02-23  8:19         ` Panu Matilainen
2015-02-23 13:55           ` Neil Horman
2015-02-23 14:20             ` Panu Matilainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150220181540.3b97dc86@urahara \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).