From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH 0/2] Move PMDs out of lib directory
Date: Fri, 8 May 2015 10:10:22 +0100 [thread overview]
Message-ID: <20150508091022.GB7376@bricha3-MOBL3> (raw)
In-Reply-To: <D17121B9.1F4D8%keith.wiles@intel.com>
On Thu, May 07, 2015 at 10:11:15PM +0100, Wiles, Keith wrote:
>
>
> On 5/7/15, 9:04 AM, "Bruce Richardson" <bruce.richardson@intel.com> wrote:
>
> >On Thu, May 07, 2015 at 05:45:20PM +0200, Marc Sune wrote:
> >>
> >>
> >> On 07/05/15 17:35, Bruce Richardson wrote:
> >> >The "lib" directory is getting very crowded, with both general libs and
> >> >poll mode drivers in it. This patch set proposes to move the PMDs out
> >>of the
> >> >lib folder and to put them in a separate "pmds" folder. This should
> >>help
> >> >with code browse-ability as the number of libs, and pmds increases.
> >> >
> >> >Comments or objections?
> >> >
> >> >Bruce Richardson (2):
> >> > pmds: Use relative rather than absolute paths
> >> > pmds: move pmds from lib to separate pmd dir
> >> >
> >> > create mode 100644 pmds/librte_pmd_xenvirt/rte_mempool_gntalloc.c
> >> > create mode 100644 pmds/librte_pmd_xenvirt/rte_xen_lib.c
> >> > create mode 100644 pmds/librte_pmd_xenvirt/rte_xen_lib.h
> >> > create mode 100644 pmds/librte_pmd_xenvirt/virtio_logs.h
> >> > create mode 100644 pmds/librte_pmd_xenvirt/virtqueue.h
> >> >
> >>
> >> But at the end they are also libraries. What about something like:
> >>
> >> * libs/core <= fundamental libraries (eal, mbuf rings...)
> >> * libs/pmds <= all pmds
> >>
> >> And other feature-group oriented, higher level lib, directories (not
> >>sure
> >> right now how to better classify them right now):
> >> * libs/processing <= packet processing
> >> * libs/utils
> >> ...
> >>
> >Yes, they are all just libs, so we could make "pmds" be a sub-dir of the
> >lib
> >folder. I prefer the shorter path myself, but if others want a multi-level
> >hierarchy it's no big deal.
>
> I like the dpdk/pmds as dpdk/lib/pmds is a bit longer, but I also see if
> we want to move the pmds to other repo(s) in the future it would be easier
> (I think) to have the subtree at the top. To me pmds are not really
> libraries as I think of libc or libcrypto or something along that path.
>
> The PMDs need to be plug able and they maybe more like loadable modules
> then libraries in the future.
>
> >
> >For the other libs, I'm not sure we need to split them up, and I also
> >think
> >that trying to divide them into categories - and what those categories
> >should
> >be could - cause endless discussion. However, maybe I'm overly
> >pessimistic... :-)
>
> I agree with Bruce here we just need the PMDS split out for now.
However, if in future we might want to split out the other libs into categories,
it may make more sense to have the pmds as a subfolder lib.
I still think I prefer having pmds at the top level of the tree, though.
/Bruce
next prev parent reply other threads:[~2015-05-08 9:10 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 15:35 Bruce Richardson
2015-05-07 15:35 ` [dpdk-dev] [RFC PATCH 1/2] pmds: Use relative rather than absolute paths Bruce Richardson
2015-05-07 15:45 ` [dpdk-dev] [RFC PATCH 0/2] Move PMDs out of lib directory Marc Sune
2015-05-07 16:04 ` Bruce Richardson
2015-05-07 21:11 ` Wiles, Keith
2015-05-08 9:10 ` Bruce Richardson [this message]
2015-05-07 15:50 ` Bruce Richardson
2015-05-11 9:47 ` Thomas Monjalon
2015-05-12 17:04 ` [dpdk-dev] [PATCH 00/19] Move PMDs to drivers directory Bruce Richardson
2015-05-12 17:04 ` [dpdk-dev] [PATCH 01/19] pmds: Use relative rather than absolute paths Bruce Richardson
2015-05-12 17:04 ` [dpdk-dev] [PATCH 02/19] drivers: create new top-level drivers directory Bruce Richardson
2015-05-12 17:04 ` [dpdk-dev] [PATCH 03/19] af_packet: move af_packet pmd to " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 04/19] bond: Move bonded ethdev pmd to drivers Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 05/19] e1000: move e1000 pmd to drivers directory Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 06/19] enic: move enic PMD " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 07/19] fm10k: move fm10k " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 08/19] i40e: move i40e " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 09/19] ixbge: move ixgbe " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 10/19] mlx4: move mlx4 " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 11/19] null pmd: move null " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 12/19] pcap: move pcap pmd " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 13/19] ring pmd: move ring PMD to the " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 14/19] virtio: move virtio PMD to " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 15/19] xmvnet3: move vmxnet3 " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 16/19] xenvirt: move xenvirt " Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 17/19] maintainers: update maintainers with driver paths Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 18/19] doc: update GSG doc for new drivers subdirectory Bruce Richardson
2015-05-12 17:05 ` [dpdk-dev] [PATCH 19/19] doc: update source organisation text for drivers Bruce Richardson
2015-05-12 19:30 ` [dpdk-dev] [PATCH 00/19] Move PMDs to drivers directory Thomas Monjalon
2015-05-13 9:01 ` Bruce Richardson
2015-05-13 13:33 ` Thomas Monjalon
2015-05-13 13:40 ` Bruce Richardson
2015-05-13 15:58 ` Bruce Richardson
2015-05-15 12:54 ` Thomas Monjalon
2015-05-15 13:14 ` Bruce Richardson
2015-05-15 12:36 ` Bruce Richardson
2015-05-15 12:50 ` Thomas Monjalon
2015-05-15 12:56 ` Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 01/19] pmds: Use relative rather than absolute paths Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 02/19] drivers: create drivers and drivers/net directory Bruce Richardson
2015-05-20 15:04 ` Thomas Monjalon
2015-05-20 15:30 ` Richardson, Bruce
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 03/19] af_packet: move af_packet pmd to " Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 04/19] bond: Move bonded ethdev pmd to drivers/net Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 05/19] e1000: move e1000 pmd to drivers/net directory Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 06/19] enic: move enic PMD " Bruce Richardson
2015-05-20 15:56 ` Thomas Monjalon
2015-05-20 16:04 ` Richardson, Bruce
2015-05-20 16:14 ` Thomas Monjalon
2015-05-20 16:45 ` Sujith Sankar (ssujith)
2015-05-20 16:52 ` Thomas Monjalon
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 07/19] fm10k: move fm10k " Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 08/19] i40e: move i40e " Bruce Richardson
2015-05-18 11:05 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 09/19] ixbge: move ixgbe " Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 10/19] mlx4: move mlx4 " Bruce Richardson
2015-05-23 4:46 ` Or Gerlitz
2015-05-23 20:37 ` Thomas Monjalon
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 11/19] null pmd: move null " Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 12/19] pcap: move pcap pmd to drivers/net Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 13/19] ring pmd: move ring PMD to the drivers directory Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 14/19] virtio: move virtio PMD to drivers/net Bruce Richardson
2015-05-15 15:56 ` [dpdk-dev] [PATCH v2 15/19] xmvnet3: move vmxnet3 " Bruce Richardson
2015-05-15 15:57 ` [dpdk-dev] [PATCH v2 16/19] xenvirt: move xenvirt " Bruce Richardson
2015-05-15 15:57 ` [dpdk-dev] [PATCH v2 17/19] maintainers: update maintainers with driver paths Bruce Richardson
2015-05-15 15:57 ` [dpdk-dev] [PATCH v2 18/19] doc: update GSG doc for new drivers subdirectory Bruce Richardson
2015-05-15 15:57 ` [dpdk-dev] [PATCH v2 19/19] doc: update source organisation text for drivers Bruce Richardson
2015-05-19 11:14 ` [dpdk-dev] [PATCH v2 00/19] Move PMDs to drivers directory Mcnamara, John
2015-05-19 11:24 ` Bruce Richardson
2015-05-19 12:01 ` Thomas Monjalon
2015-05-19 13:40 ` Thomas F Herbert
2015-05-22 14:09 ` Thomas Monjalon
2015-05-22 16:19 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508091022.GB7376@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).