From: Neil Horman <nhorman@tuxdriver.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] eal: fix compile on Fedora 22 (GCC 5.1)
Date: Fri, 29 May 2015 10:07:57 -0400 [thread overview]
Message-ID: <20150529140757.GB29575@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1432904027-6578-2-git-send-email-bruce.richardson@intel.com>
On Fri, May 29, 2015 at 01:53:44PM +0100, Bruce Richardson wrote:
> On Fedora 22, with GCC 5.1, errors are reported due to array accesses
> being potentially out of bounds. This commit fixes this by adding in an
> extra bounds check to the loop counter.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_memory.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> index 5f9f92e..744635f 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
> @@ -1188,7 +1188,8 @@ rte_eal_hugepage_init(void)
> int socket = tmp_hp[i].socket_id;
>
> /* find a hugepage info with right size and increment num_pages */
> - for (j = 0; j < (int) internal_config.num_hugepage_sizes; j++) {
> + for (j = 0; j < (int) internal_config.num_hugepage_sizes &&
> + j < MAX_HUGEPAGE_SIZES; j++) {
> if (tmp_hp[i].size ==
Use RTE_MIN here, it will look alot cleaner I think
Neil
> internal_config.hugepage_info[j].hugepage_sz) {
> #ifdef RTE_EAL_SINGLE_FILE_SEGMENTS
> --
> 2.4.1
>
>
next prev parent reply other threads:[~2015-05-29 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 12:53 [dpdk-dev] [PATCH 0/4] fix compilation on Fedora 22 Bruce Richardson
2015-05-29 12:53 ` [dpdk-dev] [PATCH 1/4] eal: fix compile on Fedora 22 (GCC 5.1) Bruce Richardson
2015-05-29 14:07 ` Neil Horman [this message]
2015-05-29 12:53 ` [dpdk-dev] [PATCH 2/4] ip_frag: " Bruce Richardson
2015-05-29 14:09 ` Neil Horman
2015-05-29 12:53 ` [dpdk-dev] [PATCH 3/4] i40e: " Bruce Richardson
2015-05-29 12:53 ` [dpdk-dev] [PATCH 4/4] null: " Bruce Richardson
2015-05-29 14:34 ` [dpdk-dev] [PATCH v2 0/4] fix compilation on Fedora 22 Bruce Richardson
2015-05-29 14:34 ` [dpdk-dev] [PATCH v2 1/4] eal: fix compile on Fedora 22 (GCC 5.1) Bruce Richardson
2015-05-29 14:34 ` [dpdk-dev] [PATCH v2 2/4] ip_frag: " Bruce Richardson
2015-05-29 14:34 ` [dpdk-dev] [PATCH v2 3/4] i40e: " Bruce Richardson
2015-05-29 14:34 ` [dpdk-dev] [PATCH v2 4/4] null: " Bruce Richardson
2015-05-29 16:57 ` [dpdk-dev] [PATCH v2 0/4] fix compilation on Fedora 22 Neil Horman
2015-06-03 14:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529140757.GB29575@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).