From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/distributor: fix missing "; " in debug macro
Date: Mon, 8 Jun 2015 11:58:10 +0100 [thread overview]
Message-ID: <20150608105810.GC3996@bricha3-MOBL3> (raw)
In-Reply-To: <19910784.6F5piXXB0d@xps13>
On Fri, Jun 05, 2015 at 10:45:04PM +0200, Thomas Monjalon wrote:
> 2015-06-05 17:01, Bruce Richardson:
> > The macro to turn on additional debug output when the app was compiled
> > with "-DDEBUG" was missing a ";".
>
> It shows that such dead code is almost never tested.
> It would be saner if this command would return no result:
> git grep 'ifdef.*DEBUG' examples
> examples/distributor/main.c:#ifdef DEBUG
> examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
> examples/packet_ordering/main.c:#ifdef DEBUG
> examples/vhost/main.c:#ifdef DEBUG
> examples/vhost/main.h:#ifdef DEBUG
> examples/vhost_xen/main.c:#ifdef DEBUG
> examples/vhost_xen/main.h:#ifdef DEBUG
>
> There is no good reason to not use CONFIG_RTE_LOG_LEVEL to trigger debug build.
>
I agree and disagree.
I agree it would be good if we had a standard way of setting up
a DEBUG build that would make it easier to test and pick up on this sort of things.
I disagree that the compile time log level is the way to do this. The log level
at compile time specifies the default log level only, the actual log level is
controllable at runtime. Having the default log level also affect what kind of
build is done, e.g. with -O0 rather than -O3, introduces an unnecessary dependency.
Setting the default log level to 5 and changing it to 9 at runtime should be
the same as setting the default to 9.
/Bruce
next prev parent reply other threads:[~2015-06-08 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 16:01 Bruce Richardson
2015-06-05 20:45 ` Thomas Monjalon
2015-06-08 10:58 ` Bruce Richardson [this message]
2015-06-10 0:33 ` Stephen Hemminger
2015-06-22 20:53 ` Thomas Monjalon
2015-06-23 16:00 ` Bruce Richardson
2015-06-22 20:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150608105810.GC3996@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).