From: Cyril Chemparathy <cchemparathy@ezchip.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros
Date: Mon, 22 Jun 2015 13:34:46 -0700 [thread overview]
Message-ID: <20150622133446.0df0b07f@cchemparathy-ubuntu> (raw)
In-Reply-To: <29909138.qD9kMyzFYN@xps13>
On Mon, 22 Jun 2015 22:16:59 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2015-06-05 15:31, Dumitrescu, Cristian:
> > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to
> > > meta-data fields.
> > > Forcing aligned accesses is not really required, so this is
> > > removing an unneeded constraint.
> > > This issue was met during testing of the new version of the
> > > ip_pipeline application. There is no performance impact.
> > > This change has no ABI impact, as the previous code that uses
> > > aligned accesses continues to run without any issues.
> > >
> > > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> >
> > Ack-ed by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Applied, thanks
>
> Cyril, feel free to fix it if it breaks with Tile arch.
Also, in the code, doesn't the following break when mbuf_priv_size != 0?
> #define RTE_MBUF_METADATA_UINT8_PTR(mbuf, offset) \
> (&((uint8_t *) &(mbuf)[1])[offset])
Thanks
-- Cyril.
prev parent reply other threads:[~2015-06-22 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 14:55 Daniel Mrzyglod
2015-06-05 15:31 ` Dumitrescu, Cristian
2015-06-22 20:16 ` Thomas Monjalon
2015-06-22 20:23 ` Cyril Chemparathy
2015-06-22 20:42 ` Thomas Monjalon
2015-06-22 20:34 ` Cyril Chemparathy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622133446.0df0b07f@cchemparathy-ubuntu \
--to=cchemparathy@ezchip.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).