From: Cyril Chemparathy <cchemparathy@ezchip.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 08/12] mempool: allow config override on element alignment
Date: Tue, 23 Jun 2015 13:43:04 -0700 [thread overview]
Message-ID: <20150623134304.55c7233d@cchemparathy-ubuntu> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A1CDB8@irsmsx105.ger.corp.intel.com>
On Tue, 23 Jun 2015 00:31:06 +0000
"Ananyev, Konstantin" <konstantin.ananyev@intel.com> wrote:
> > +#define RTE_MEMPOOL_ALIGN_MASK (RTE_MEMPOOL_ALIGN - 1)
>
> I am probably a bit late with my comments, but why not make it a
> runtime decision then? I know we can't add a new parameter to
> mempool_xmem_create() without ABI breakage, but we can make some
> global variable for now, that could be setup at init time or
> something similar.
But then, a global variable that is modified by an application _is_ a
part of the ABI, and a bad one at that.
I agree with the desire to make it runtime configurable, but I think we
should do so in the right spirit, with the appropriate interfaces, and
when we're open to changing the ABI accordingly.
Thanks
-- Cyril.
next prev parent reply other threads:[~2015-06-23 20:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1434999524-26528-1-git-send-email-cchemparathy@ezchip.com>
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 01/12] test: limit x86 cpuflags checks to x86 builds Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 02/12] hash: fix compilation on non-X86 platforms Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 03/12] hash: check SSE flags only on x86 builds Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 04/12] eal: allow empty compile time flags Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 05/12] config: remove RTE_LIBNAME definition Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 06/12] memzone: refactor rte_memzone_reserve() variants Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 07/12] memzone: allow multiple pagesizes to be requested Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 08/12] mempool: allow config override on element alignment Cyril Chemparathy
2015-06-23 0:31 ` Ananyev, Konstantin
2015-06-23 20:43 ` Cyril Chemparathy [this message]
2015-06-23 21:21 ` Ananyev, Konstantin
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 09/12] tile: add page sizes for TILE-Gx/Mx platforms Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 10/12] tile: initial TILE-Gx support Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 11/12] tile: Add TILE-Gx mPIPE poll mode driver Cyril Chemparathy
2015-06-22 18:58 ` [dpdk-dev] [PATCH v2 12/12] maintainers: claim responsibility for TILE-Gx platform Cyril Chemparathy
2015-06-24 16:42 ` [dpdk-dev] [PATCH v2 00/12] Introducing the " Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623134304.55c7233d@cchemparathy-ubuntu \
--to=cchemparathy@ezchip.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).