From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 01/13] port: added structures for port stats and config option
Date: Tue, 23 Jun 2015 11:16:53 -0400 [thread overview]
Message-ID: <20150623151653.GA17251@hmsreliant.think-freely.org> (raw)
In-Reply-To: <2173119.kJ61eenqfH@xps13>
On Tue, Jun 23, 2015 at 03:55:25PM +0200, Thomas Monjalon wrote:
> 2015-06-19 11:41, Maciej Gajdzica:
> > /** Input port interface defining the input port operation */
> > struct rte_port_in_ops {
> > rte_port_in_op_create f_create; /**< Create */
> > rte_port_in_op_free f_free; /**< Free */
> > rte_port_in_op_rx f_rx; /**< Packet RX (packet burst) */
> > + rte_port_in_op_stats_read f_stats; /**< Stats */
> > };
>
> Isn't it breaking an ABI?
>
This is an interesting question. Strictly speaking, yes it breaks ABI because
we're adding space, and if older applications statically allocate this
structure, it will be smaller than the port library expects, potentially
scribbling over someone elses memory. That said, I'm not sure this structure is
meant to be accessed outside of the library. If it isn't, then we can feel
comfortable that no one is going to access the data structure from code that was
compiled out of sync with the defining library.
The implication if thats true of course is that we should make this structure
opaque outside of the library with a structure prototype and move its definition
into the library private namespace, but I'm fine with doing that at a later date
if the intention is not to have applications touch this structure.
Regards
Neil
> > struct rte_port_out_ops {
> > - rte_port_out_op_create f_create; /**< Create */
> > - rte_port_out_op_free f_free; /**< Free */
> > - rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */
> > - rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */
> > - rte_port_out_op_flush f_flush; /**< Flush */
> > + rte_port_out_op_create f_create; /**< Create */
> > + rte_port_out_op_free f_free; /**< Free */
> > + rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */
> > + rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */
> > + rte_port_out_op_flush f_flush; /**< Flush */
>
> What is the goal of this change? Breaking the alignment?
>
> > + rte_port_out_op_stats_read f_stats; /**< Stats */
>
>
next prev parent reply other threads:[~2015-06-23 15:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 9:41 [dpdk-dev] [PATCH v5 00/13] port: added port statistics Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 01/13] port: added structures for port stats and config option Maciej Gajdzica
2015-06-23 10:26 ` Dumitrescu, Cristian
2015-06-23 13:55 ` Thomas Monjalon
2015-06-23 14:30 ` Dumitrescu, Cristian
2015-06-23 14:54 ` Thomas Monjalon
2015-06-23 15:21 ` Dumitrescu, Cristian
2015-06-23 15:16 ` Neil Horman [this message]
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 02/13] port: added port_ethdev_reader stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 03/13] port: added port_ethdev_writer stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 04/13] port: added port_ethdev_writer_nodrop stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 05/13] port: added port_frag stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 06/13] port: added port_ras stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 07/13] port: added port_ring_reader stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 08/13] port: added port_ring_writer stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 09/13] port: added port_ring_writer_nodrop stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 10/13] port: added port_sched_reader stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 11/13] port: added port_sched_writer stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 12/13] port: added port_source stats Maciej Gajdzica
2015-06-19 9:41 ` [dpdk-dev] [PATCH v5 13/13] port: added port_sink stats Maciej Gajdzica
2015-06-23 10:31 ` [dpdk-dev] [PATCH v5 00/13] port: added port statistics Dumitrescu, Cristian
2015-06-23 21:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623151653.GA17251@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).