From: Matthew Hall <mhall@mhcomputing.net>
To: Cunming Liang <cunming.liang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix negative value for undetermined numa_node
Date: Fri, 31 Jul 2015 20:56:55 -0700 [thread overview]
Message-ID: <20150801035655.GA29805@mhcomputing.net> (raw)
In-Reply-To: <1438306572-25434-1-git-send-email-cunming.liang@intel.com>
I asked about this many months ago and was informed that "-1" is a "standard
error value" that I should expect from these APIs when NUMA is not present.
Now we're saying I have to change my code again to handle a zero value?
Also not sure how to tell the difference between no NUMA, something running on
socket zero, and something with multiple sockets. Seems like we need a bit of
thought about how the NUMA APIs should behave overall.
Matthew.
On Fri, Jul 31, 2015 at 09:36:12AM +0800, Cunming Liang wrote:
> The patch sets zero as the default value of pci device numa_node
> if the socket could not be determined.
> It provides the same default value as FreeBSD which has no NUMA support,
> and makes the return value of rte_eth_dev_socket_id() be consistent
> with the API description.
>
> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
next prev parent reply other threads:[~2015-08-01 3:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 6:33 [dpdk-dev] [PATCH v1] app/test: fix pmd_perf issue in no NUMA case Cunming Liang
2015-06-08 7:01 ` Jayakumar, Muthurajan
2015-06-22 21:01 ` Thomas Monjalon
2015-06-23 1:45 ` Liang, Cunming
2015-07-31 1:36 ` [dpdk-dev] [PATCH] eal/linux: fix negative value for undetermined numa_node Cunming Liang
2015-08-01 3:56 ` Matthew Hall [this message]
2015-08-03 1:46 ` Liang, Cunming
2015-08-03 5:04 ` Matthew Hall
2015-08-03 17:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801035655.GA29805@mhcomputing.net \
--to=mhall@mhcomputing.net \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).