From: Dan Aloni <dan@kernelim.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mempool: fix the inverted pg_num check on create
Date: Mon, 17 Aug 2015 13:50:01 +0300 [thread overview]
Message-ID: <20150817105001.GC15603@gmail.com> (raw)
In-Reply-To: <55D1A187.7080802@6wind.com>
On Mon, Aug 17, 2015 at 10:55:35AM +0200, Olivier MATZ wrote:
> On 08/16/2015 09:08 PM, Dan Aloni wrote:
[..]
> > /* Check that pg_num and pg_shift parameters are valid. */
> > - if (pg_num < RTE_DIM(mp->elt_pa) || pg_shift > MEMPOOL_PG_SHIFT_MAX) {
> > + if (pg_num > RTE_DIM(mp->elt_pa) || pg_shift > MEMPOOL_PG_SHIFT_MAX) {
> > rte_errno = EINVAL;
> > return NULL;
>
> From what I see, RTE_DIM(mp->elt_pa) is always 1:
>
> #define MEMPOOL_PG_NUM_DEFAULT 1
> struct rte_mempool {
> ...
> phys_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT];
> } __rte_cache_aligned;
>
> From rte_mempool_xmem_create() documentation, pg_num gives the size of
> the paddr array, which is allocated by the caller. So I think there is
> no issue here.
You're right, I missed on the fact that mempool takes pg_num as its
run-time determined size of the array for both its dynamically allocated
copy and the caller's provided array.
The MEMPOOL_PG_NUM_DEFAULT macro is was a bit distracting in this. I
wanted to provide pg_num > 1 and it wasn't clear on whether to modify
the macro, or simply call the function :). So, never mind the patch.
--
Dan Aloni
prev parent reply other threads:[~2015-08-17 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 19:08 Dan Aloni
2015-08-17 8:55 ` Olivier MATZ
2015-08-17 10:50 ` Dan Aloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817105001.GC15603@gmail.com \
--to=dan@kernelim.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).