From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: use existing PCI macros
Date: Thu, 10 Sep 2015 20:33:00 +0100 [thread overview]
Message-ID: <20150910193300.GA32153@sivlogin002.ir.intel.com> (raw)
In-Reply-To: <CALwxeUuh3JWTxRbw5sRmrgn4neaEqNdh8OW6Ppkdet3Kcohe4g@mail.gmail.com>
Hi David,
> Hello Ferruh,
>
> On Thu, Sep 10, 2015 at 6:01 PM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
>
> > To get pci_dev and vf number from dev, benefit from
> > existing macros in pci.h
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
>
> Correct me if I am wrong but you might need to provide wrappers for kernel
> version <= 2.6.34 (or something that indicates availability of those).
Correct, those macros available after kernel version >= 2.6.34.
If these is any chance that one using older kernel than this version,
instead of having wrappers I am for keeping existing implementation and
drop this patch.
>
> Please, can you confirm this is just a cleanup and you are not fixing
> anything ?
Just cleanup.
Thanks,
ferruh
next prev parent reply other threads:[~2015-09-10 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 16:01 Ferruh Yigit
2015-09-10 16:33 ` David Marchand
2015-09-10 19:33 ` Ferruh Yigit [this message]
2015-09-11 8:10 ` Thomas Monjalon
2015-09-11 8:31 ` Mcnamara, John
2015-10-25 17:51 ` Thomas Monjalon
2015-11-24 22:03 ` Thomas Monjalon
2015-11-24 22:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910193300.GA32153@sivlogin002.ir.intel.com \
--to=ferruh.yigit@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).