From: Jan Viktorin <viktorin@rehivetech.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 4/6] eal/arm: fix 64-bit armv8 compilation of rte_cpuflags.h
Date: Fri, 30 Oct 2015 13:46:40 +0100 [thread overview]
Message-ID: <20151030134640.70e9b57d@pcviktorin.fit.vutbr.cz> (raw)
In-Reply-To: <1446205886-23823-5-git-send-email-david.hunt@intel.com>
Much better then the previous...
Reviewed-by: Jan Viktorin <viktorin@rehivetech.com>
On Fri, 30 Oct 2015 11:51:24 +0000
David Hunt <david.hunt@intel.com> wrote:
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> lib/librte_eal/common/include/arch/arm/rte_cpuflags.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_cpuflags.h b/lib/librte_eal/common/include/arch/arm/rte_cpuflags.h
> index 7ce9d14..5c5fd6a 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_cpuflags.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_cpuflags.h
> @@ -141,12 +141,16 @@ rte_cpu_get_features(__attribute__((unused)) uint32_t leaf,
> __attribute__((unused)) uint32_t subleaf, cpuid_registers_t out)
> {
> int auxv_fd;
> +#ifdef RTE_ARCH_64
> + Elf64_auxv_t auxv;
> +#else
> Elf32_auxv_t auxv;
> +#endif
>
> auxv_fd = open("/proc/self/auxv", O_RDONLY);
> assert(auxv_fd);
> while (read(auxv_fd, &auxv,
> - sizeof(Elf32_auxv_t)) == sizeof(Elf32_auxv_t)) {
> + sizeof(auxv)) == sizeof(auxv)) {
> if (auxv.a_type == AT_HWCAP)
> out[REG_HWCAP] = auxv.a_un.a_val;
> else if (auxv.a_type == AT_HWCAP2)
--
Jan Viktorin E-mail: Viktorin@RehiveTech.com
System Architect Web: www.RehiveTech.com
RehiveTech
Brno, Czech Republic
next prev parent reply other threads:[~2015-10-30 12:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 11:51 [dpdk-dev] [PATCH v2 0/6] ARMv8 additions to ARMv7 support David Hunt
2015-10-30 11:51 ` [dpdk-dev] [PATCH v2 1/6] eal/arm: add 64-bit armv8 version of rte_memcpy.h David Hunt
2015-10-30 11:51 ` [dpdk-dev] [PATCH v2 2/6] eal/arm: add 64-bit armv8 version of rte_prefetch.h David Hunt
2015-10-30 11:51 ` [dpdk-dev] [PATCH v2 3/6] eal/arm: add 64-bit armv8 version of rte_cycles.h David Hunt
2015-10-30 12:44 ` Jan Viktorin
2015-10-30 13:18 ` Hunt, David
2015-10-30 11:51 ` [dpdk-dev] [PATCH v2 4/6] eal/arm: fix 64-bit armv8 compilation of rte_cpuflags.h David Hunt
2015-10-30 12:46 ` Jan Viktorin [this message]
2015-10-30 11:51 ` [dpdk-dev] [PATCH v2 5/6] mk: add support for armv8 on top of armv7 David Hunt
2015-10-30 12:49 ` Jan Viktorin
2015-10-30 11:51 ` [dpdk-dev] [PATCH v2 6/6] test: add checks for cpu flags on armv8 David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030134640.70e9b57d@pcviktorin.fit.vutbr.cz \
--to=viktorin@rehivetech.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).