From: Bruce Richardson <bruce.richardson@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper
Date: Mon, 2 Nov 2015 10:33:56 +0000 [thread overview]
Message-ID: <20151102103355.GA5688@bricha3-MOBL3> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA61282A54A@IRSMSX102.ger.corp.intel.com>
On Mon, Nov 02, 2015 at 10:28:35AM +0000, Van Haaren, Harry wrote:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Subject: Re: [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper
> >
> > 2015-10-30 16:16, Bruce Richardson:
> > > Another request, can you perhaps also fix the script for situations where
> > > checkpatch.pl is not in the kernel tree.
> > > <snip>
>
> > OK
> > I prefer using it in the Linux tree because it is updated with "git pull".
>
> I would like to suggest including the checkpatch.pl script itself in the dpdk tree, as this would ensure that we are all running the exact same version of checkpatch.
>
> My previous patchset had errors that I had not detected because I ran an older checkpatch.pl, and I think there are others who have similar issues that the checkpatch version provides more/less errors.
>
> If included in the repo, we would all automatically upgrade when the next checkpatch.pl is merged - providing consistency.
>
> -Harry
+1
/Bruce
next prev parent reply other threads:[~2015-11-02 10:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 15:53 [dpdk-dev] [PATCH 0/2] more basic tests Thomas Monjalon
2015-10-23 15:53 ` [dpdk-dev] [PATCH 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-10-23 16:03 ` Stephen Hemminger
2015-10-23 16:34 ` Thomas Monjalon
2015-10-23 16:56 ` Stephen Hemminger
2015-10-23 16:58 ` Stephen Hemminger
2015-10-23 20:27 ` Thomas Monjalon
2015-10-29 12:17 ` Bruce Richardson
2015-10-29 12:33 ` David Marchand
2015-10-29 13:03 ` Thomas Monjalon
2015-10-29 13:24 ` Bruce Richardson
2015-10-29 13:34 ` Thomas Monjalon
2015-10-29 13:48 ` Bruce Richardson
2015-10-29 13:54 ` David Marchand
2015-10-29 13:57 ` Thomas Monjalon
2015-10-30 16:16 ` Bruce Richardson
2015-10-30 16:23 ` Thomas Monjalon
2015-11-02 10:28 ` Van Haaren, Harry
2015-11-02 10:33 ` Bruce Richardson [this message]
2015-10-23 15:53 ` [dpdk-dev] [PATCH 2/2] scripts: add build tests Thomas Monjalon
2015-11-23 1:40 ` [dpdk-dev] [PATCH v2 0/2] more basic tests Thomas Monjalon
2015-11-23 1:40 ` [dpdk-dev] [PATCH v2 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-11-24 16:33 ` Bruce Richardson
2015-11-23 1:40 ` [dpdk-dev] [PATCH v2 2/2] scripts: add build tests Thomas Monjalon
2015-11-24 17:49 ` Mcnamara, John
2015-11-24 18:14 ` Thomas Monjalon
2015-12-03 17:39 ` [dpdk-dev] [PATCH v2 0/2] more basic tests Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102103355.GA5688@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).