From: Eric Kinzie <ehkinzie@gmail.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org, Eric Kinzie <ekinzie@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine
Date: Mon, 2 Nov 2015 11:42:09 -0500 [thread overview]
Message-ID: <20151102164206.GA14543@roosta.home> (raw)
In-Reply-To: <563739B3.1040809@redhat.com>
On Mon Nov 02 12:23:47 +0200 2015, Panu Matilainen wrote:
> On 11/01/2015 08:17 PM, Thomas Monjalon wrote:
> >2015-10-19 08:36, Eric Kinzie:
> >> Size of struct rte_eth_bond_8023ad_conf changed. Increment LIBABIVER
> >> and version bond_mode_8023ad_setup and bond_mode_8023ad_conf_get
> >> functions.
> >[...]
> >>+VERSION_SYMBOL(bond_mode_8023ad_setup, _v20, 2.0);
> >[...]
> >>+BIND_DEFAULT_SYMBOL(bond_mode_8023ad_setup, _v22, 2.2);
> >>+MAP_STATIC_SYMBOL(void bond_mode_8023ad_setup(struct rte_eth_dev *dev, struct rte_eth_bond_8023ad_conf *conf), \
> >>+ bond_mode_8023ad_setup_v22);
> >
> >I'm sorry it doesn't work well when trying to build a combined lib:
> >
> >ld: libdpdk.so: version node not found for symbol bond_mode_8023ad_setup@@DPDK_2.2
> >
> >The symbols are OK in the .o file:
> >0000000000002340 g F .text 0000000000000171 bond_mode_8023ad_setup@@DPDK_2.2
> >0000000000002260 g F .text 00000000000000da bond_mode_8023ad_setup@DPDK_2.0
> >0000000000002260 g F .text 00000000000000da bond_mode_8023ad_setup_v20
> >0000000000002340 g F .text 0000000000000171 bond_mode_8023ad_setup_v22
> >0000000000000000 *UND* 0000000000000000 bond_mode_8023ad_setup
> >
> >I don't understand the problem and I am considering disabling versioning in
> >combined library.
> >
> >Any idea?
> >
>
> The .map additions look incorrect to me:
>
> >diff --git a/drivers/net/bonding/rte_eth_bond_version.map b/drivers/net/bonding/rte_eth_bond_version.map
> >index 22bd920..7f78717 100644
> >--- a/drivers/net/bonding/rte_eth_bond_version.map
> >+++ b/drivers/net/bonding/rte_eth_bond_version.map
> >@@ -17,6 +17,9 @@ DPDK_2.0 {
> > rte_eth_bond_slaves_get;
> > rte_eth_bond_xmit_policy_get;
> > rte_eth_bond_xmit_policy_set;
> >+ rte_eth_bond_8023ad_ext_collect;
> >+ rte_eth_bond_8023ad_ext_distrib;
> >+ rte_eth_bond_8023ad_ext_slowtx;
>
> These symbols didn't exist in DPDK 2.0 but are only being added
> here. So why are they being added to the 2.0 section?
Yes, I think these should probably be moved.
> >
> > local: *;
> > };
> >@@ -27,3 +30,10 @@ DPDK_2.1 {
> > rte_eth_bond_free;
> >
> > } DPDK_2.0;
> >+
> >+DPDK_2.2 {
> >+ local
> >+
> >+ bond_mode_8023ad_conf_get;
> >+ bond_mode_8023ad_setup;
> >+} DPDK_2.1;
>
> These are marked local, as in, "not exported" which doesn't seem
> right. Also they're lacking the rte_eth_ prefix. AFAICS this is what
> the symbol export map should look like here:
These were not exported to begin with. But after versioning these
functions, they are exported unless explicitly declared to be local here.
> DPDK_2.2 {
> global:
>
> rte_eth_bond_8023ad_ext_collect;
> rte_eth_bond_8023ad_ext_distrib;
> rte_eth_bond_8023ad_ext_slowtx;
> rte_eth_bond_mode_8023ad_conf_get;
> rte_eth_bond_mode_8023ad_setup;
> } DPDK_2.1;
>
> That said, problems with symbol versioning and the combined library
> were predicted from the start, once the individual library versions
> start advancing. For one, the combined library itself is not
> versioned at all it is offending the ABI policy all the time.
>
> Replacing the library with a linker script, as suggested before by
> Neil Horman and Sergio Gonzales Monroy would eliminate these
> problems.
>
> - Panu -
>
>
next prev parent reply other threads:[~2015-11-02 16:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 15:36 [dpdk-dev] [PATCH v6 0/4] bonding corrections and additions Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 1/4] bond mode 4: copy entire config structure Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 2/4] bond mode 4: do not ignore multicast Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine Eric Kinzie
2015-11-01 18:17 ` Thomas Monjalon
2015-11-01 23:17 ` [dpdk-dev] [PATCH] mk: fix ABI versioning compile error for combined shared library Ferruh Yigit
2015-11-01 23:24 ` Thomas Monjalon
2015-11-02 0:05 ` Ferruh Yigit
2015-11-02 7:10 ` Thomas Monjalon
2015-11-02 10:20 ` Ferruh Yigit
2015-11-02 15:23 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-11-02 16:26 ` Thomas Monjalon
2015-11-02 19:18 ` Ferruh Yigit
2015-11-03 7:06 ` Panu Matilainen
2015-11-03 9:20 ` Ferruh Yigit
2015-11-03 10:41 ` Panu Matilainen
2015-11-03 11:33 ` Ferruh Yigit
2015-11-03 11:43 ` Panu Matilainen
2015-11-06 13:58 ` [dpdk-dev] [PATCH] " Ferruh Yigit
2015-11-06 13:58 ` Ferruh Yigit
2015-11-02 10:23 ` [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine Panu Matilainen
2015-11-02 16:42 ` Eric Kinzie [this message]
2015-11-03 6:48 ` Panu Matilainen
2015-11-03 8:16 ` Thomas Monjalon
2015-11-03 8:30 ` Panu Matilainen
2015-11-03 9:38 ` Thomas Monjalon
2015-11-03 17:12 ` Eric Kinzie
2015-11-03 11:02 ` Ferruh Yigit
2015-11-03 11:31 ` Panu Matilainen
2015-11-03 11:48 ` Ferruh Yigit
2015-11-20 19:46 ` Eric Kinzie
2015-11-24 14:52 ` Panu Matilainen
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 4/4] bond mode 4: tests for " Eric Kinzie
2015-10-19 16:27 ` [dpdk-dev] [PATCH v6 0/4] bonding corrections and additions Declan Doherty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102164206.GA14543@roosta.home \
--to=ehkinzie@gmail.com \
--cc=dev@dpdk.org \
--cc=ekinzie@brocade.com \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).