From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 3/8] virtio/lib:add vhost TX checksum support capabilities
Date: Thu, 12 Nov 2015 09:41:49 +0800 [thread overview]
Message-ID: <20151112014149.GE2326@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20151111093114.46bb40ee@xeon-e3>
On Wed, Nov 11, 2015 at 09:31:14AM -0800, Stephen Hemminger wrote:
> On Wed, 11 Nov 2015 16:26:57 +0800
> Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote:
>
> > On Wed, Nov 11, 2015 at 02:40:41PM +0800, Jijiang Liu wrote:
> > > Add vhost TX offload(CSUM and TSO) support capabilities.
> >
> > Claiming first that we support something, and then actually implementing
> > in a later patch is wrong, as at this stage, we actually does not support
> > that, hence, the functionality is broken.
> >
> > --yliu
>
> Actually in this case it is okay to claim that driver "might" use offload
> cabability but never do it.
But it will not work once it does use it, right?
--yliu
> But agree in general better to keep both together.
next prev parent reply other threads:[~2015-11-12 1:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 6:40 [dpdk-dev] [PATCH v4 0/8] add virtio offload support in us-vhost Jijiang Liu
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 1/8] driver/virtio:add virtual address for virtio net header Jijiang Liu
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 2/8] driver/virtio:record virtual address of " Jijiang Liu
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 3/8] virtio/lib:add vhost TX checksum support capabilities Jijiang Liu
2015-11-11 8:26 ` Yuanhan Liu
2015-11-11 17:31 ` Stephen Hemminger
2015-11-12 1:41 ` Yuanhan Liu [this message]
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 4/8] virtio/lib:dequeue vhost TX offload Jijiang Liu
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure defination Jijiang Liu
2015-11-11 8:34 ` Yuanhan Liu
2015-11-11 10:05 ` Thomas Monjalon
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 6/8] examples/vhost:support TX offload in vhost sample Jijiang Liu
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities Jijiang Liu
2015-11-11 8:31 ` Yuanhan Liu
2015-11-11 8:38 ` Liu, Jijiang
2015-11-11 8:44 ` Yuanhan Liu
2015-11-11 8:53 ` Liu, Jijiang
2015-11-11 8:57 ` Xu, Qian Q
2015-11-11 11:10 ` Liu, Jijiang
2015-11-11 10:08 ` Thomas Monjalon
2015-11-11 12:53 ` Yuanhan Liu
2015-11-11 6:40 ` [dpdk-dev] [PATCH v4 8/8] virtio/lib:add guest offload handle Jijiang Liu
2015-11-11 8:23 ` Yuanhan Liu
2015-11-11 10:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112014149.GE2326@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).