From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/7] ether: don't mark input multicast for deprecation
Date: Thu, 12 Nov 2015 14:10:53 -0800 [thread overview]
Message-ID: <20151112141053.5f2f9bba@xeon-e3> (raw)
In-Reply-To: <1446771879-3979-2-git-send-email-stephen@networkplumber.org>
On Thu, 5 Nov 2015 17:04:33 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The number of received multicast frames is useful and already
> available in many/most drivers. Therefore don't mark it as
> deprecated.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
> lib/librte_ether/rte_ethdev.h | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 0b0bbcf..3b71c0c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2715,7 +2715,6 @@ ixgbevf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
> stats->opackets = hw_stats->vfgptc;
> stats->obytes = hw_stats->vfgotc;
> stats->imcasts = hw_stats->vfmprc;
> - /* stats->imcasts should be removed as imcasts is deprecated */
> }
>
> static void
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 48a540d..f653e37 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -204,8 +204,7 @@ struct rte_eth_stats {
> /**< Deprecated; Total of RX packets with bad length. */
> uint64_t ierrors; /**< Total number of erroneous received packets. */
> uint64_t oerrors; /**< Total number of failed transmitted packets. */
> - uint64_t imcasts;
> - /**< Deprecated; Total number of multicast received packets. */
> + uint64_t imcasts; /**< Total number of multicast received packets. */
> uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */
> uint64_t fdirmatch;
> /**< Deprecated; Total number of RX packets matching a filter. */
I am okay with removing imcasts if all the drivers that support provide
the same information in xstats.
next prev parent reply other threads:[~2015-11-12 22:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 1:04 [dpdk-dev] [PATCH v2 0/7] ethdev: force deprecation of statistics Stephen Hemminger
2015-11-06 1:04 ` [dpdk-dev] [PATCH 1/7] ether: don't mark input multicast for deprecation Stephen Hemminger
2015-11-12 16:52 ` Thomas Monjalon
2015-11-12 22:10 ` Stephen Hemminger [this message]
2015-11-06 1:04 ` [dpdk-dev] [PATCH 2/7] bond: don't sum deprecated statistics Stephen Hemminger
2015-11-06 1:04 ` [dpdk-dev] [PATCH 3/7] cxgbe: don't report " Stephen Hemminger
2015-11-06 1:04 ` [dpdk-dev] [PATCH 4/7] i40e: " Stephen Hemminger
2015-11-06 1:04 ` [dpdk-dev] [PATCH 5/7] e1000: " Stephen Hemminger
2015-11-06 1:04 ` [dpdk-dev] [PATCH 6/7] test-pmd: remove references to " Stephen Hemminger
2015-11-06 1:04 ` [dpdk-dev] [PATCH 7/7] rte_ether: mark deprecated statistics with attribute Stephen Hemminger
2015-11-12 22:03 ` Thomas Monjalon
2015-11-12 22:07 ` [dpdk-dev] [PATCH v2 0/7] ethdev: force deprecation of statistics Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112141053.5f2f9bba@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).